Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vkMZy-00E46M-1W for pgsql-hackers@arkaria.postgresql.org; Mon, 26 Jan 2026 13:24:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vkMZx-008CAz-1M for pgsql-hackers@arkaria.postgresql.org; Mon, 26 Jan 2026 13:24:29 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vkMZx-008CAa-0B for pgsql-hackers@lists.postgresql.org; Mon, 26 Jan 2026 13:24:29 +0000 Received: from mail-yw1-x112e.google.com ([2607:f8b0:4864:20::112e]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vkMZu-002Ohu-1U for pgsql-hackers@postgresql.org; Mon, 26 Jan 2026 13:24:28 +0000 Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-7944693b824so21788777b3.3 for ; Mon, 26 Jan 2026 05:24:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1769433866; cv=none; d=google.com; s=arc-20240605; b=EJWGwV6B10msx+kGQLXFhZhYRd97OAiACvZY7elxCFud9JJC7vhrtp47VzCC0Egki3 z3TPyvBB81+neoyubaABeiHZhtJt0/84yQ2XBnpXJ/8LonBjoA4fN4hBlewDUVM9fYqg buug7nKY4AnplqHEkZ0F+/pRZlLFENNL1n9IA0cIHySAKEFfe/6lj+mLhbt+7mnF05I+ AqdWq4F8Ymn6ZR/fxrYs/ODXcLOYN3MH7CyTElpadNmbD0HxQm+QWOwGeWk+QSfNIeya Jp2zCS+WVunlmMrxr0DAbVBMp5s9jjFjw7aO8EK46baH0s39o2C3N3IlY5nbBtzv34UD sjIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=msqPFLZJIOU2uolF2toviYkZviSY8uN4czTbS+54pgQ=; fh=hcw5BbVb9s9fzlA0xEm4w1KL17A/MQ0NOkdlVb9jhe0=; b=HRamlwVwJjVcoT9WmbdvCif1LIyao44ntETkcih22N7zFoZKdip/p4s4iyDp9kogAO 33CigcetiZEpofpWtBhgG3L9gWD0Me/fM2ueF3YkqbzfCMRaAEe1GzaiJCTAOx1HkDmr S1p01ahxwvx+3NvdREVQpq1yov7AAxkL0KU0eykUVyib6L9ip0q/RzzbYqIFip2mGrAG nUILW5xdzEcPQrwWNJcBzhlTT0CF/k6DFoxiC+QeMSZBuPsnWLGpM7flu/LdCyvfVHQG 4AMEe052dC7Zg32AcLT/Rpefy4lqKBOu/CjyU+TfX3ac2dZdxRNuK9RGuBQiJ4oZnnVD RqQg==; darn=postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=percona.com; s=google; t=1769433866; x=1770038666; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=msqPFLZJIOU2uolF2toviYkZviSY8uN4czTbS+54pgQ=; b=SKoitKkzdzYQ280SPhpJDfO+zerjXfRh6i3q0gI/Xffio9faJc4DS9q8rKuLqFIDQb UsxwkDz9uZB6uOP0Dt2pHlE14vWW49GEI6BMrnPT7fVacY4kfNRHUy2pi9kFFTPUxdFu pQHQv0TCYh9eUYsqEtk4wfa1pt+KY+NIAZHVI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769433866; x=1770038666; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=msqPFLZJIOU2uolF2toviYkZviSY8uN4czTbS+54pgQ=; b=giH9FaOzDYR0dfsR7KAGj6FHpvOupYSP9ehaW9vweLUOpXPkeB7ogury/vz4UxCEXt CKhXswXt/BiuQb/ecykpyDb9I5AGeVZH7KC9orBrlJJd4KX1reBqc3raWJhHpgTdy+sT S5TwbNN5qi5rEPTxDHdP1A0xs/1ssowiRlzEZrqvryCLTpkxhZu3w/ilkmZfDq3X0eoV AJ2nKfQ6hVhH2Z2D285WwOYDVTbyjVyxgjO1ceNUmRlCVDq3FXYgIXTMCapFmCnp+MSc Zq9EEjG3qaNfoSeBsN93sVAlKNPYUZq3G6PWxpT1nod9V/ghEdfDSjGVGRMVGUOUongg 7Mpw== X-Gm-Message-State: AOJu0YyMJ+FXIy/jvEctADSCiEA1qqGg+Y+IG41MLn4fBn4ebKJ7vf9s 5LM9Mn3bd6BjfAQm+UsTDFWA87JF1q7jNFhTcOhtrpw6cpQ9Y42TkElFRNrLUE01lsXAgQ8PlvQ nYBYBhy4q3ypkAOW5IyedG+B772CikkbjfWBtKhZrLJZdDOFddbabDkzpVysXRIHDaQCWLfT9FP YScRvaDyw363OeCImRtkZwr106PtS6ua6kHqei3pfn9jUYUQK/sa6877qacSB6r9d5kU8O3/41Q kcXDESyIkuDWRI/F3YpQJySUh0ydPIi9wel+AY3yKEXoyC9PU0= X-Gm-Gg: AZuq6aJbM7yhW48yfJ9Am1jX80/LCbblpkwKdaP3zXc4jR0KSbAiKA2P2PeioTEQzIm ZEwH4sI4dKn65Zin5Lcwc53OhUy8t45zIMkDMTP82/9z6aZ+yBAhDLf4nD6OgenDr++8fZMEg/+ Bhq8+r5ZjNr0/UJmSRvGIi2bxD0JGOWPxRLtxk5e3X73mDahGSC6gguGvgc3KdjRISCwe99A6HK VhlPFQBUHqcjFHcLcttnT09McARWUz2ESOM6+OSsiiyUaR1iE+ka3Y1T7hitbhR5NOy95PDwjI9 VTzLU1hryeBRe/A+8hKZmjIl6z3xkSyYIO+PbQ4WKRhgIrTeUdMlZmHC X-Received: by 2002:a05:690c:c92:b0:786:5c6f:d242 with SMTP id 00721157ae682-7945a9f9ddamr38123867b3.69.1769433866279; Mon, 26 Jan 2026 05:24:26 -0800 (PST) MIME-Version: 1.0 References: <1981b5f0-7d06-4911-a231-23bbb6bf504c@gmail.com> In-Reply-To: <1981b5f0-7d06-4911-a231-23bbb6bf504c@gmail.com> From: Zsolt Parragi Date: Mon, 26 Jan 2026 13:24:15 +0000 X-Gm-Features: AZwV_QiQeyvbptopbkdp04nYmTJ82jFSMX3JSZwVvdyTkudUEDOD7QxYqrH82LY Message-ID: Subject: Re: Use correct collation in pg_trgm To: David Geier Cc: pgsql-hackers , Heikki Linnakangas , Kirill Reshke Content-Type: text/plain; charset="UTF-8" X-CLOUD-SEC-AV-Sent: true X-CLOUD-SEC-AV-Info: percona,google_mail,monitor X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > While reading through [1] I realized that the word boundary detection > also uses the wrong collation. Patch 0002 fixes that. Good catch, I considered checking that when I reviewed the patch, but I thought that it would be an issue with CJK languages, and I was completely wrong about that. Updated patch looks good, I only noticed two minor things: * the new test should have a newline at the end of the file * and probably a conditional skip based on locale availability, the citext_utf8.sql test case does something similar