MIME-Version: 1.0
References: 
 <CA+TgmoZ-Jh1T6QyWoCODMVQdhTUPYkaZjWztzP1En4=ZHoKPzw@mail.gmail.com>
 <CAKZiRmxtJAFG7e1+Vs9B8ngON=AOzJbuws+1ZeH4LsbJh5AzoQ@mail.gmail.com>
 <CA+TgmoY9Ne_Sh10u6LSPc3wvOQPLp3kF9nBp3nqJEG2JGF2QiA@mail.gmail.com>
 <CA+Tgmoa57S6mP=aTOXH2-gDAL4TMO1WbGgrHSg0s6J4zUH=04g@mail.gmail.com>
 <DEB1SAGVDX7S.JMV96X4R0RCS@gmail.com>
 <CA+Tgmoaf__2B0BUL+vrg28P+3buX=Ti-kybqkHiLTtFrrCfzuA@mail.gmail.com>
 <CA+TgmoYpcLNOuypOTdgCSLW7FuA=t6BtB3meTARHX2-Dj_81xQ@mail.gmail.com>
 <DEFNP3WX7BLX.1X7DS1P9X6JIF@nmfay.com>
 <CA+TgmoZjv9OyFu1Gkt78w0vWEti8S33w8trYHmErf-GMmGSi=w@mail.gmail.com>
 <DELPC4B56Y5A.3OBZ3WCH3T4VX@nmfay.com>
 <CA+TgmoaOSBQD9Ux4eG40w723ZN=c0J7p-+oX4+J8urUeyLMo5w@mail.gmail.com>
 <CAOYmi+=g+MMoOpWkk2weXWKJcKH0eKey8gKHHdH0dF4Tiawrhw@mail.gmail.com>
 <CA+TgmobwaT=PXPDDrgDup+jA8KHBbkxigtziD-zNzAKKkQYVgQ@mail.gmail.com>
 <CAOYmi+mOmEW=amDRQMfw6-Fb3ZmDEQFaJzwk8Bc8W8DzaP85XQ@mail.gmail.com>
 <CA+TgmoaX2AMW4cdFM3OngBJxmxpkdmzF33R7-CWhvRLfucbFMg@mail.gmail.com>
 <CAOYmi+k4AyWCQHK=XVF99KVDuFkqxcADao61OWGLxu0nRYMONQ@mail.gmail.com>
 <CA+TgmoZ0x3ym_oueXRWzbM_=6ucKoPZVGj3rRMLBDC_FnetXDw@mail.gmail.com>
 <CAP53Pkycc=7N2bLzVT3x+qE1JamvRZWev5tFjdLJ1+-AV3Di+Q@mail.gmail.com>
 <CA+TgmoaKhuD91RnazbRyGkmP7--JdNq8oNDC3UcgTZSWbMxC7w@mail.gmail.com>
 <CAP53Pkw5-wMEeDJXFmqo_RTyL_spzCXb7HHKrbSnQqokVoZcNQ@mail.gmail.com>
 <CA+Tgmob-69bzbdi3U_QtebqAf6u1y8js=5=oNK639csVe1VbhA@mail.gmail.com>
 <CA+TgmoaZMOikxK=LqS+Jn+835h9S139JLGk-3LyETVXw5W5j=w@mail.gmail.com>
 <1136161.1769654478@sss.pgh.pa.us>
 <CAP53PkwZ1ZTMARKg6iEfAw9qzBhkjBitj-9gr_Jvy7k2AwGgWA@mail.gmail.com>
 <CAMbWs4--NuEUFE_xTo991TRXaZryE29jarJPDnVxoaQOYdt7tA@mail.gmail.com>
 <CA+TgmobzR+XMGbRosVPbjHbSo4+cgJn=qZK6w05aF1sbj=C+9Q@mail.gmail.com>
 <CA+TgmoawzvCoZAwFS85tE5+c8vBkqgcS8ZstQ_ohjXQ9wGT9sw@mail.gmail.com>
 <CA+TgmoYS4ZCVAF2jTce=bMP0Oq_db_srocR4cZyO0OBp9oUoGg@mail.gmail.com>
 <CAK98qZ2RzbgCHrSg4zLkvpzyBam_X6te-KF8w1+_vON9BAVMEw@mail.gmail.com>
 <CA+TgmoaCdsuvNn6T6SfQ_0YD2Hh2+hgTXh9fTGHQhPg1zvy2rQ@mail.gmail.com>
 <CAK98qZ1zWzRB0ABG7ULzTeWKRR5C7-FxLqM-6v8wQDiFM+DNAg@mail.gmail.com>
 <CA+Tgmob7ozJAs5SU6bD2RfAt4w_AmsMGz-aaVA6WeLXHkBypOg@mail.gmail.com>
 <CAK98qZ1J42RoAsHnYWGPPmHziZmzmqE=Lp_O6WJ-9aKK2qjikA@mail.gmail.com>
 <CA+TgmoYjcBA6dw3nwiyfDzPXTCrxTZPXDMrc2TrDJcL1cPK6iA@mail.gmail.com>
 <CA+TgmoYru-vxoTKfwjQby30r2OkTXfb18Km_=VLs6qk8Akr0-g@mail.gmail.com>
 <CAKFQuwYxTMx1e1dvVLd5vs8CO2Xe__YRCW0m4v2UErG=5Lu7kQ@mail.gmail.com>
 <CA+TgmoaPH3rOmH1zw8s10Az3TQKRbDnF3dKYZCAFvx_DgFV5_Q@mail.gmail.com>
 <CAKFQuwZ7CRbvmJ60EjvEUJP8X9hWVCHJz8yJZ0-xRpYwL=fugA@mail.gmail.com>
 <CA+TgmoYsG2pAOG4YYWwnGsaL+QfOZopi_m+f_hZqBZ3meNEkjg@mail.gmail.com>
 <CAKFQuwY4i6xXCRHd=ccrFz0sQOfiWRxhobiBrzyK0rzu1-Y33Q@mail.gmail.com>
 <CA+Tgmobbj_TaCsYmr1grJBTRKaFaxFfotXn1T6LSXs9GQ8_Kyw@mail.gmail.com>
 <CA+TgmoZzM2i+p-Rxdphs4qx7sshn-kzxF91ASQ5duOo0dFRXLQ@mail.gmail.com>
In-Reply-To: 
 <CA+TgmoZzM2i+p-Rxdphs4qx7sshn-kzxF91ASQ5duOo0dFRXLQ@mail.gmail.com>
From: Zsolt Parragi <zsolt.parragi@percona.com>
Date: Sat, 14 Mar 2026 15:06:04 +0000
Message-ID: 
 <CAN4CZFP6NOjv__4Mx+iQD8StdpbHvzDAatEQn2n15UKJ=MySSQ@mail.gmail.com>
Subject: Re: pg_plan_advice
To: Robert Haas <robertmhaas@gmail.com>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000aebbed064cfd5395"
Archived-At: 
 <https://www.postgresql.org/message-id/CAN4CZFP6NOjv__4Mx%2BiQD8StdpbHvzDAatEQn2n15UKJ%3DMySSQ%40mail.gmail.com>
Precedence: bulk

--000000000000aebbed064cfd5395
Content-Type: text/plain; charset="UTF-8"

Hello

I noticed a difference between installed headers with make and meson,
which is caused by pg_plan_advice.h. It is completely missing from the
make build, and installs to the wrong location with meson.

Please see the attached patch that fixes this.

--000000000000aebbed064cfd5395
Content-Type: application/octet-stream;
	name="0001-Fix-pg_plan_advice-header-install-discrepancy-betwee.patch"
Content-Disposition: attachment;
	filename="0001-Fix-pg_plan_advice-header-install-discrepancy-betwee.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mmqgiaaa0>
X-Attachment-Id: f_mmqgiaaa0

RnJvbSBmNzJkNzYwYjg3NDZmYzhiNTdjNjY0MWRkNWE3OTlkNmE4NGU3NmQzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBac29sdCBQYXJyYWdpIDx6c29sdC5wYXJyYWdpQHBlcmNvbmEu
Y29tPgpEYXRlOiBTYXQsIDE0IE1hciAyMDI2IDE0OjI5OjQ5ICswMDAwClN1YmplY3Q6IFtQQVRD
SF0gRml4IHBnX3BsYW5fYWR2aWNlIGhlYWRlciBpbnN0YWxsIGRpc2NyZXBhbmN5IGJldHdlZW4g
bWFrZQogYW5kIG1lc29uCgpUaGUgTWFrZWZpbGUgd2FzIG1pc3NpbmcgaGVhZGVyIGluc3RhbGxh
dGlvbiBlbnRpcmVseSwgYW5kIHRoZSBtZXNvbgpidWlsZCB3YXMgaW5zdGFsbGluZyB0byBleHRl
bnNpb24vIGRlc3BpdGUgcGdfcGxhbl9hZHZpY2Ugbm90IGhhdmluZwphIGNvbnRyb2wgZmlsZS4K
CkZpeCBib3RoOiBhZGQgSEVBREVSU19wZ19wbGFuX2FkdmljZSB0byB0aGUgTWFrZWZpbGUsIGFu
ZCBjaGFuZ2UgbWVzb24KdG8gaW5zdGFsbCB0byBjb250cmliLyB0byBtYXRjaC4KLS0tCiBjb250
cmliL3BnX3BsYW5fYWR2aWNlL01ha2VmaWxlICAgIHwgMiArKwogY29udHJpYi9wZ19wbGFuX2Fk
dmljZS9tZXNvbi5idWlsZCB8IDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCsp
LCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvY29udHJpYi9wZ19wbGFuX2FkdmljZS9NYWtl
ZmlsZSBiL2NvbnRyaWIvcGdfcGxhbl9hZHZpY2UvTWFrZWZpbGUKaW5kZXggZDJhODIzM2YzODcu
LmNkNDc4ZGMxYTZkIDEwMDY0NAotLS0gYS9jb250cmliL3BnX3BsYW5fYWR2aWNlL01ha2VmaWxl
CisrKyBiL2NvbnRyaWIvcGdfcGxhbl9hZHZpY2UvTWFrZWZpbGUKQEAgLTE1LDYgKzE1LDggQEAg
T0JKUyA9IFwKIAlwZ3BhX3Ryb3ZlLm8gXAogCXBncGFfd2Fsa2VyLm8KIAorSEVBREVSU19wZ19w
bGFuX2FkdmljZSA9IHBnX3BsYW5fYWR2aWNlLmgKKwogUEdGSUxFREVTQyA9ICJwZ19wbGFuX2Fk
dmljZSAtIGhlbHAgdGhlIHBsYW5uZXIgZ2V0IHRoZSByaWdodCBwbGFuIgogCiBSRUdSRVNTID0g
Z2F0aGVyIGpvaW5fb3JkZXIgam9pbl9zdHJhdGVneSBwYXJ0aXRpb253aXNlIHByZXBhcmVkIFwK
ZGlmZiAtLWdpdCBhL2NvbnRyaWIvcGdfcGxhbl9hZHZpY2UvbWVzb24uYnVpbGQgYi9jb250cmli
L3BnX3BsYW5fYWR2aWNlL21lc29uLmJ1aWxkCmluZGV4IGNmOTQ4ZmZhYTEzLi4zNmJiYzRlOTgy
NiAxMDA2NDQKLS0tIGEvY29udHJpYi9wZ19wbGFuX2FkdmljZS9tZXNvbi5idWlsZAorKysgYi9j
b250cmliL3BnX3BsYW5fYWR2aWNlL21lc29uLmJ1aWxkCkBAIC00NCw3ICs0NCw3IEBAIGNvbnRy
aWJfdGFyZ2V0cyArPSBwZ19wbGFuX2FkdmljZQogCiBpbnN0YWxsX2hlYWRlcnMoCiAgICdwZ19w
bGFuX2FkdmljZS5oJywKLSAgaW5zdGFsbF9kaXI6IGRpcl9pbmNsdWRlX2V4dGVuc2lvbiAvICdw
Z19wbGFuX2FkdmljZScsCisgIGluc3RhbGxfZGlyOiBkaXJfaW5jbHVkZV9zZXJ2ZXIgLyAnY29u
dHJpYicgLyAncGdfcGxhbl9hZHZpY2UnLAogKQogCiB0ZXN0cyArPSB7Ci0tIAoyLjQzLjAKCg==
--000000000000aebbed064cfd5395--