MIME-Version: 1.0
References: 
 <CAN4CZFPmF9fGOcFubwOxqXymhVo_RvbUx3bLoYQcfk=f0mwECw@mail.gmail.com>
 <202601281620.m3hrqtih5b2w@alvherre.pgsql>
 <CAN4CZFPUfTj-BF-m5=F7_MnY_T3+Qh-DuG7N7ojdbJDkT8JHeA@mail.gmail.com>
 <fd412b8e-fab5-43fe-b18d-3e035e4998a7@nataraj.su>
 <CAN4CZFMCh3vOWGPbU5pTB-bwnoAtgFuDJmGGv7z7xeez+WJiag@mail.gmail.com>
 <CAN4CZFMGwGdMnxP07Rk2qrC9eGQt31Lrerrnk66vQuzRhDEwiw@mail.gmail.com>
 <CAOYmi+nTXGcroZD_Mnkc8LYWYFbfDYNR4ML_yQ5sF9+DY2amcg@mail.gmail.com>
 <CAN4CZFMxQzFD0ZJS7pX5Ajdei7TmpROEZKG5vxmfmhCQEQX3fA@mail.gmail.com>
 <CAOYmi+mUdsTODm0F8PWBQYcCQPBKvHUAieXgoP1pWXtEA2N9Aw@mail.gmail.com>
 <CAN4CZFOdfRKjmpsDHWG_3Qgtmkcd41GFBH1uenC9-5yUj=hBzA@mail.gmail.com>
 <CAOYmi+nUCSoMuQBm+2z_-98mMB6F5SDABA2X8CMoo==5O4v13A@mail.gmail.com>
 <CAOYmi+k4fuYKJBW0GuCZFWOz3w+0t=X9zeHFx2avr3=kdpopQw@mail.gmail.com>
 <CAOYmi+=_otQRpW4L2VZms4dzF12_0fTJREBWEUOApmAaxSJ8bA@mail.gmail.com>
In-Reply-To: 
 <CAOYmi+=_otQRpW4L2VZms4dzF12_0fTJREBWEUOApmAaxSJ8bA@mail.gmail.com>
From: Zsolt Parragi <zsolt.parragi@percona.com>
Date: Mon, 6 Apr 2026 23:09:27 +0100
Message-ID: 
 <CAN4CZFPCHdY2j1+EHDhU+G+8+bp_jXh3Jqqf+2wqeYDBiQbjVA@mail.gmail.com>
Subject: Re: Custom oauth validator options
To: Jacob Champion <jacob.champion@enterprisedb.com>
Cc: Nikolay Shaplov <dhyan@nataraj.su>,
 =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
	VASUKI M <vasukianand0119@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 david.g.johnston@gmail.com,
	Robert Haas <robertmhaas@gmail.com>, myon@debian.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAN4CZFPCHdY2j1%2BEHDhU%2BG%2B8%2Bbp_jXh3Jqqf%2B2wqeYDBiQbjVA%40mail.gmail.com>
Precedence: bulk

> I believe this is now a complete patch
> proposal; tear it apart. :D

The patch looks good to me as is, I don't see any real issues with it,
maybe one cosmetic question in the test.

+ if (GetOAuthHBAOption(state, "log"))
+ elog(LOG, "%s", GetOAuthHBAOption(state, "log"));
+

If we treat the test code as an example for real implementations, this
and the other use could cache the option in a local variable instead
of making duplicate calls, following the pattern of the documentation.