MIME-Version: 1.0
References: <DDPQ1RV5FE9U.I2WW34NGRD8Z@jeltef.nl>
 <DFJ3E1X9169E.WV892I950LYW@jeltef.nl>
 <DFY0RHAZTTXJ.15AD95RE6A5N5@jeltef.nl>
 <CAN4CZFOw2v9G_9vuP0vnNH8K9X_UeSOyq=gWJp7bdGZ5HKNTDA@mail.gmail.com>
 <DG9X4XC66EMC.2S34SS1SZ8K3K@jeltef.nl> <DGBMBCDXXNBG.3CNHEZ9QVB4GL@jeltef.nl>
 <CAN4CZFMLpakQb8qohDAnrOoQ1-UrvmzJewZss95Y+Mf_J+iNeA@mail.gmail.com>
 <DH1JZEYZOBSW.1QEY6MI45FCIL@jeltef.nl>
 <f97528e4-5766-415e-b998-678da925ce05@vondra.me>
 <CAOYmi+mAJ5jF-XrxFz1BAcAPfJCm9Yy1uvRNwfNz8q+1YMKDig@mail.gmail.com>
 <DHB31JSR3PTE.3J3PBIXA6JBB2@jeltef.nl>
In-Reply-To: <DHB31JSR3PTE.3J3PBIXA6JBB2@jeltef.nl>
From: Zsolt Parragi <zsolt.parragi@percona.com>
Date: Tue, 24 Mar 2026 22:21:19 +0000
Message-ID: 
 <CAN4CZFPYS4iDCK3oYs3zp77K50ra6C=Hvg5-ymt9KR0OFmuGQA@mail.gmail.com>
Subject: Re: Add GoAway protocol message for graceful but fast server
 shutdown/switchover
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: Jacob Champion <jacob.champion@enterprisedb.com>,
 Tomas Vondra <tomas@vondra.me>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Dave Cramer <davecramer@gmail.com>,
	Heikki Linnakangas <hlinnaka@iki.fi>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAN4CZFPYS4iDCK3oYs3zp77K50ra6C%3DHvg5-ymt9KR0OFmuGQA%40mail.gmail.com>
Precedence: bulk

+ if (!goaway_reported && PQgoAwayReceived(pset.db))
+ {
+ pg_log_info("Server sent GoAway, requesting disconnect when convenient.");
+ goaway_reported = true;
+ }

Shouldn't this variable be reset in pqDropServerData?

+    It is possible for NoticeResponse, ParameterStatus and GoAway
messages to be
     interspersed between CopyData messages; frontends must handle these cases,

The patch currently doesn't actually do this, did you add this as
future proofing?


> I thought some more about this, but ultimately, the payloads you suggest
> only seem useful if a client has something inbetween "disconnect hard
> now" and "disconnect when the connection is unused"

Couldn't a client optimize the reconnect time if it knows about the
deadline? If it knows that it still has 10 minutes before the server
kicks it out, it might choose to finish a 3-4 minute task, reconnect,
and then continue.