MIME-Version: 1.0
References: <7db341e0-fbc6-4ec5-922c-11fdafe7be12@tantorlabs.com>
 <c5c7cf37-218d-405a-8dde-520aa313830a@gmail.com> <988e3168-6096-488a-bb42-787e1e8c21a4@tantorlabs.com>
 <21FF6A0B-886F-4132-B6A6-0F4E934B4CEE@Outlook.com> <8ee9d903-bb13-434c-8145-b3769bf2b3cb@tantorlabs.com>
 <ff7d491d-f084-4935-8417-c0b7285cdd89@gmail.com> <CAHza6qdAH99C0xa27YDTixiNVFa99j90QYquUPAxL0JwahmggA@mail.gmail.com>
 <9e3054ae-1c5d-46dd-9b6a-7fb67764b076@tantorlabs.com>
In-Reply-To: <9e3054ae-1c5d-46dd-9b6a-7fb67764b076@tantorlabs.com>
From: Zsolt Parragi <zsolt.parragi@percona.com>
Date: Wed, 25 Feb 2026 21:39:05 +0000
Message-ID: <CAN4CZFPb+iqQkby4AGvZSvL2OkwQ+S9CVvmJiQ=u6cckWPetqA@mail.gmail.com>
Subject: Re: Hash-based MCV matching for large IN-lists
To: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
Cc: Tatsuya Kawata <kawatatatsuya0913@gmail.com>, David Geier <geidav.pg@gmail.com>, 
	Chengpeng Yan <chengpeng_yan@outlook.com>, 
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAN4CZFPb%2BiqQkby4AGvZSvL2OkwQ%2BS9CVvmJiQ%3Du6cckWPetqA%40mail.gmail.com>
Precedence: bulk

Hello

+ hashContext.hash_fcinfo = hash_fcinfo;
+ hashContext.op_is_reversed = !hash_mcv;
+ hashContext.insert_mode = true;

Are you sure about op_is_reversed, isn't it backwards, shouldn't it be
= hash_mcv instead?

See the following testcase:

CREATE TABLE test_cross_type_bug (val float4);

INSERT INTO test_cross_type_bug
    SELECT v
      FROM generate_series(1, 200) AS v,
           generate_series(1, 50);

ALTER TABLE test_cross_type_bug ALTER COLUMN val SET STATISTICS 200;
ANALYZE test_cross_type_bug;

SELECT string_agg(v::text, ', ') AS in_list
  FROM generate_series(1, 200) AS gs(v) \gset

EXPLAIN SELECT * FROM test_cross_type_bug
 WHERE val = ANY(ARRAY[:in_list]::float4[]);

EXPLAIN SELECT * FROM test_cross_type_bug
 WHERE val = ANY(ARRAY[:in_list]::float8[]);

DROP TABLE test_cross_type_bug;