MIME-Version: 1.0
References: 
 <CAGRkXqRHsZw3+aeNZgnBYduQSY7qg1O4MBdmyFjK-A+TU1-b-A@mail.gmail.com>
 <CAGRkXqRp+mK_uuCEp+wuBvuvFf_1v=MGC6Dd6HgJigJUzZanHg@mail.gmail.com>
 <tencent_347FA4C66CA7706C2188382FDAB2B7280705@qq.com>
 <CAGRkXqTaxN+cqNz-qaMRWmcXC7SVmgTAb++6MZwpXTZj-EUB0A@mail.gmail.com>
In-Reply-To: 
 <CAGRkXqTaxN+cqNz-qaMRWmcXC7SVmgTAb++6MZwpXTZj-EUB0A@mail.gmail.com>
From: Zsolt Parragi <zsolt.parragi@percona.com>
Date: Tue, 24 Mar 2026 22:11:01 +0000
Message-ID: 
 <CAN4CZFPf-VhzkXMsWjncXBVBc9vjw2tasJz99iN6MMCaMLna6g@mail.gmail.com>
Subject: Re: [Patch] New pg_stat_tablespace view
To: shihao zhong <zhong950419@gmail.com>
Cc: songjinzhou <tsinghualucky912@foxmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAN4CZFPf-VhzkXMsWjncXBVBc9vjw2tasJz99iN6MMCaMLna6g%40mail.gmail.com>
Precedence: bulk

Hello!

blk_read_time and blk_write_time doesn't seem to work, they show 0 to
me even after some workloads, and I don't see any assignments in the
code. The testcase also checks for "blk_read_time >= 0" which
trivially succeeds.

blocks_fetched is also misleading, it includes both reads and cache
hits. pg_stat_database calls this column blocks_read, and properly
substracts blocks_hit from it.

+ rel->pgstat_info->reltablespace = rel->rd_locator.spcOid;

Shouldn't this be included in TwoPhasePgStatRecord / pgstat_twophase_postcommit?