MIME-Version: 1.0
References: <0b555318-2bf2-46df-9377-09629a2a59db@uni-muenster.de>
 <97B93CF6-109D-46B4-AD50-8908DD4BE6E4@gmail.com>
 <039cca2d-5574-4dad-92e6-6e72c1747b23@uni-muenster.de>
In-Reply-To: <039cca2d-5574-4dad-92e6-6e72c1747b23@uni-muenster.de>
From: Zsolt Parragi <zsolt.parragi@percona.com>
Date: Wed, 25 Mar 2026 20:38:25 +0000
Message-ID: 
 <CAN4CZFPgxc4_BMjkss=UATpxUF-koPRxOeXL819gn3PD=vy8Ng@mail.gmail.com>
Subject: Re: VACUUM FULL, CLUSTER,
 and REPACK block on other sessions' temp tables
To: Jim Jones <jim.jones@uni-muenster.de>
Cc: Chao Li <li.evan.chao@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Antonin Houska <ah@cybertec.at>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAN4CZFPgxc4_BMjkss%3DUATpxUF-koPRxOeXL819gn3PD%3Dvy8Ng%40mail.gmail.com>
Precedence: bulk

Hello!

Shouldn't the patch also include a tap test to verify that the change
works / fails without it?

+ /* Skip temp relations belonging to other sessions */
+ {
+ Oid nsp = get_rel_namespace(index->indrelid);
+
+ if (!isTempOrTempToastNamespace(nsp) && isAnyTempNamespace(nsp))
+ {

Doesn't this result in several repeated syscache lookups?

There's already a SearchSysCacheExsists1 directly above this, then a
get_rel_namespace, then an isAnyTempNamespace. While this probably
isn't performance critical, this should be doable with a single
SearchSysCache1(RELOID...) and then a few conditions, similarly to the
else branch below this?