MIME-Version: 1.0
References: <FCF996D0-580B-431C-8DE1-A540C58E444C@gmail.com>
In-Reply-To: <FCF996D0-580B-431C-8DE1-A540C58E444C@gmail.com>
From: Nazir Bilal Yavuz <byavuz81@gmail.com>
Date: Wed, 13 May 2026 12:57:50 +0300
Message-ID: 
 <CAN55FZ05TxsGxJXJ4u-BJW=dc=ycGw96fNYzOMMuEFAa-MUynA@mail.gmail.com>
Subject: Re: Fix jsonpath .split_part() to honor silent mode
To: Chao Li <li.evan.chao@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Florents Tselai <florents.tselai@gmail.com>,
 Andrew Dunstan <andrew@dunslane.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAN55FZ05TxsGxJXJ4u-BJW%3Ddc%3DycGw96fNYzOMMuEFAa-MUynA%40mail.gmail.com>
Precedence: bulk

Hi,

Thank you for working on this!

On Tue, 12 May 2026 at 05:11, Chao Li <li.evan.chao@gmail.com> wrote:
>
> While testing the new json_path method split_part(), I noticed that it do=
esn=E2=80=99t honor silent mode. I think this is a v19-new bug.
>
> After looking into the code, I think the root cause is that .decimal() us=
es numeric_int4_safe() to parse integer arguments, while the .split_part() =
path in executeStringInternalMethod() uses numeric_int4() directly, which r=
aises an error immediately for invalid values.
>
> The attached patch fixes this by switching the .split_part() path to use =
numeric_int4_safe() and report the argument errors through the jsonpath err=
or handling mechanism.
>
> Please see the attached patch for details.

I think you are right and I confirm that your patch fixes the problem.

--
Regards,
Nazir Bilal Yavuz
Microsoft