MIME-Version: 1.0
References: <CAN55FZ0FRB2OD6-oEESLvgUT4bLZQVD72pAqUqzdw7Rx5cN0ig@mail.gmail.com>
 <CA+K2Run1VdLnmp-5_Qv2Fax0KgT7LLJMH-uzjaaf-NZD1oU-=w@mail.gmail.com>
 <aYZdKSTw6N3khsVE@nathan> <CAN55FZ2DOeLjSXE2Jos99bgHG-Zeo3KjStrSgoA8Rf=2Mu+hFA@mail.gmail.com>
 <aYZvdsXPElQvwWOA@nathan> <CAN55FZ1=O6TjeZM2CUT7T2tu66uJT+w3G9FiRXVs+gt_ousFxQ@mail.gmail.com>
 <aY0FL4rXUl6ykn-a@nathan> <CAN55FZ3g6QaiC8G4GMjdJ24egvgc-HG_xpoOztxnM_wnQNn5aw@mail.gmail.com>
 <aY-vJe_ENCB-fux9@nathan> <CAN55FZ2OpqRxUUEvgPpHCk2HnY0xZSH1x09fgFGOUyXSv8HcEA@mail.gmail.com>
 <aZYudtuBLVb36pZE@nathan>
In-Reply-To: <aZYudtuBLVb36pZE@nathan>
From: Nazir Bilal Yavuz <byavuz81@gmail.com>
Date: Thu, 19 Feb 2026 00:54:20 +0300
Message-ID: <CAN55FZ0J5iz9wFJLHcK7yNQqPb10_4ROoZiDu1wBZWSGC_fATg@mail.gmail.com>
Subject: Re: Speed up COPY FROM text/CSV parsing using SIMD
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: KAZAR Ayoub <ma_kazar@esi.dz>, Neil Conway <neil.conway@gmail.com>, 
	Manni Wood <manni.wood@enterprisedb.com>, Andrew Dunstan <andrew@dunslane.net>, 
	Shinya Kato <shinya11.kato@gmail.com>, 
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAN55FZ0J5iz9wFJLHcK7yNQqPb10_4ROoZiDu1wBZWSGC_fATg%40mail.gmail.com>
Precedence: bulk

Hi,

On Thu, 19 Feb 2026 at 00:26, Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> On Wed, Feb 18, 2026 at 04:38:07PM +0300, Nazir Bilal Yavuz wrote:
> > By looking at these results having both is_csv and simd_enabled as an
> > argument and sending them as constant boolean arguments help most.
>
> Thanks for doing these tests.  ISTM we might as well get this initial
> inlining stuff committed.  Thoughts?

nitpick:

-static bool CopyReadLineText(CopyFromState cstate, bool is_csv);
+static pg_attribute_always_inline bool CopyReadLineText(CopyFromState cstate,
+                                                        bool is_csv);

Do we want to move the new CopyReadLineText() declaration below to
group it with the other functions marked pg_attribute_always_inline?

Other than that, LGTM. I think it makes sense to separately commit this.

-- 
Regards,
Nazir Bilal Yavuz
Microsoft