MIME-Version: 1.0
References: 
 <CAMSWrt-PoQt4sHryWrB1ViuGBJF_PpbjoSGrWR2Ry47bHNLDqg@mail.gmail.com>
 <fd9864f9-30bf-450b-a025-5e1bba58591a@eisentraut.org>
 <CAMSWrt-A0ha0qANftNYGpa8vEbtiD_7iV+0mdP0g9V8va=K0YA@mail.gmail.com>
In-Reply-To: 
 <CAMSWrt-A0ha0qANftNYGpa8vEbtiD_7iV+0mdP0g9V8va=K0YA@mail.gmail.com>
From: Nazir Bilal Yavuz <byavuz81@gmail.com>
Date: Fri, 28 Nov 2025 18:05:12 +0300
Message-ID: 
 <CAN55FZ1OkRkQMT==EtTWesKBFdBG28WrzhYsex3UG67F7bAQ8A@mail.gmail.com>
Subject: Re: [PATCH] Add `headerscheck` run_target to meson
To: =?UTF-8?Q?Mi=C5=82osz_Bieniek?= <bieniek.milosz0@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>,
 pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAN55FZ1OkRkQMT%3D%3DEtTWesKBFdBG28WrzhYsex3UG67F7bAQ8A%40mail.gmail.com>
Precedence: bulk

Hi,

Thank you for working on this!

On Fri, 28 Nov 2025 at 17:03, Mi=C5=82osz Bieniek <bieniek.milosz0@gmail.co=
m> wrote:
>
> pt., 28 lis 2025 o 12:53 Peter Eisentraut <peter@eisentraut.org> napisa=
=C5=82(a):
> >
> > On 27.11.25 10:28, Mi=C5=82osz Bieniek wrote:
> > > While reviewing a patch I noticed that we have a `make -s headerschec=
k`
> > > but there is no equivalent in meson.
> > > I prepared a small patch that adds `headerscheck` and `cpluspluscheck=
`
> > > targets.
> >
> > This would be good to have, but I don't think your patch works.  It
> > seems you need to add the srcdir and builddir command-line arguments to
> > the invocations.
> >
>
> I think you are right. I added srcdir and builddir arguments.

The headerscheck script pulls some information from Makefile.global
after the configure [1] but meson does not generate a full version of
Makefile.global [2], so it does not have the required information to
check perl and python headers. If you run 'meson compile
headerscheck', you get errors like:

In file included from
/home/nbyavuz/Desktop/projects/postgres/src/pl/plperl/plperl.h:25,
                 from /tmp/headerscheck.YxsZhn/test.c:2:
/home/nbyavuz/Desktop/projects/postgres/src/pl/plperl/plperl_system.h:85:10=
:
fatal error: EXTERN.h: No such file or directory
   85 | #include <EXTERN.h>
      |          ^~~~~~~~~~
compilation terminated.

In file included from
/home/nbyavuz/Desktop/projects/postgres/src/pl/plpython/plpython.h:39,
                 from
/home/nbyavuz/Desktop/projects/postgres/src/pl/plpython/plpy_plpymodule.h:8=
,
                 from /tmp/headerscheck.YxsZhn/test.c:2:
/home/nbyavuz/Desktop/projects/postgres/src/pl/plpython/plpython_system.h:5=
0:10:
fatal error: Python.h: No such file or directory
   50 | #include <Python.h>
      |          ^~~~~~~~~~
compilation terminated.

-----

[1.1] src/tools/pginclude/headerscheck
# Needs to be run after configuring and creating all generated headers.
# It's advisable to configure --with-perl --with-python, else you're
# likely to get errors from associated headers.

[1.2] src/tools/pginclude/headerscheck
# Pull some info from configure's results.
MGLOB=3D"$builddir/src/Makefile.global"
CPPFLAGS=3D`sed -n 's/^CPPFLAGS[     ]*=3D[     ]*//p' "$MGLOB"`
CFLAGS=3D`sed -n 's/^CFLAGS[     ]*=3D[     ]*//p' "$MGLOB"`
ICU_CFLAGS=3D`sed -n 's/^ICU_CFLAGS[     ]*=3D[     ]*//p' "$MGLOB"`
CC=3D`sed -n 's/^CC[     ]*=3D[     ]*//p' "$MGLOB"`
CXX=3D`sed -n 's/^CXX[     ]*=3D[     ]*//p' "$MGLOB"`
PG_SYSROOT=3D`sed -n 's/^PG_SYSROOT[     ]*=3D[     ]*//p' "$MGLOB"`
perl_includespec=3D`sed -n 's/^perl_includespec[     ]*=3D[     ]*//p' "$MG=
LOB"`
python_includespec=3D`sed -n 's/^python_includespec[     ]*=3D[     ]*//p' =
"$MGLOB"`

[2] src/meson.build
makefile_global =3D configure_file(
  input: 'Makefile.global.in',
  output: 'Makefile.global',
  configuration: pgxs_cdata,
  install: true,
  install_dir: dir_pgxs / 'src',
)
configure_files +=3D makefile_global

--=20
Regards,
Nazir Bilal Yavuz
Microsoft