MIME-Version: 1.0
References: <aa73q1aT0A3/vke/@ip-10-97-1-34.eu-west-3.compute.internal>
 <44885d54-0376-46b3-b574-59e0e3098580@eisentraut.org>
 <dfb1373e-258f-42b7-ac76-0f5858936dfa@eisentraut.org>
In-Reply-To: <dfb1373e-258f-42b7-ac76-0f5858936dfa@eisentraut.org>
From: Nazir Bilal Yavuz <byavuz81@gmail.com>
Date: Wed, 18 Mar 2026 18:50:20 +0300
Message-ID: 
 <CAN55FZ1VDwJ-ZD092ChYf++huP+-S3Cg45tJ8jNH5wx2c4BHAg@mail.gmail.com>
Subject: Re: Enable -Wstrict-prototypes and -Wold-style-definition by default
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
 pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAN55FZ1VDwJ-ZD092ChYf%2B%2BhuP%2B-S3Cg45tJ8jNH5wx2c4BHAg%40mail.gmail.com>
Precedence: bulk

Hi,

Thank you for working on this!

On Wed, 18 Mar 2026 at 16:32, Peter Eisentraut <peter@eisentraut.org> wrote=
:
>
> On 16.03.26 10:55, Peter Eisentraut wrote:
> > On 09.03.26 17:39, Bertrand Drouvot wrote:
> >> 0001: Prevent -Wstrict-prototypes and -Wold-style-definition warnings
> >>
> >> It fixes the remaining warnings that those new flags would generate.
> >
> > I have committed this one.  I'll look at the rest next.
>
> Also committed.

I got this warning while running headerscheck after this commit:

~/Desktop/projects/postgres/src/interfaces/ecpg/ecpglib/ecpglib_extern.h:22=
1:40:
warning: function declaration isn=E2=80=99t a prototype [-Wstrict-prototype=
s]
  221 | void            ecpg_init_sqlca(struct sqlca_t *sqlca)

Another topic is that, CI already catched this [1] (and other not
related things in cpluspluscheck). However, it seems that since we run
headerscheck and cpluspluscheck with the '-fmax-errors=3D10' option; CI
didn't fail. It would be good to remove '-fmax-errors=3D10', though.

[1] https://cirrus-ci.com/task/5166361724321792?logs=3Dheaders_headerscheck=
#L0

--
Regards,
Nazir Bilal Yavuz
Microsoft