MIME-Version: 1.0
References: 
 <CAN55FZ3jXs7XDsP_-v_jUBquRu4uAdheN3xcmW=WhAyKwFLSjg@mail.gmail.com>
 <abGv0ScUWVa6eogw@nathan>
 <CAN55FZ3gdK8dGrEo0M6KFW97OaF8TUbjO_dFoxQKi63davE-jA@mail.gmail.com>
 <abG8R6HkOHyUuyWb@nathan>
 <CAN55FZ0yfETy4UEA5rOJ9S06JSOtiWF8TW_+yi3yjVAcrLqKLA@mail.gmail.com>
 <abHTvkeIK37hj9oS@nathan>
 <CAN55FZ1sn-2tVX_n9C5UNBCfDPjSDOCT4zkMeDsB7MaZ9SUBTw@mail.gmail.com>
 <abL5ylYjmopRRmvy@nathan>
 <CAN55FZ0oYuVHZ=TdJofj0WA3mG77XumVsGJgG8gnav9kexr+wg@mail.gmail.com>
 <CAN55FZ0ocS6cBHEWqHv2s-dK91U6OdVLBqj7VexTehtBtioDbA@mail.gmail.com>
 <abQZmZ0KZesCxfR0@nathan>
 <43de48dc-701b-4735-881b-50bca6870f39@app.fastmail.com>
In-Reply-To: <43de48dc-701b-4735-881b-50bca6870f39@app.fastmail.com>
From: Nazir Bilal Yavuz <byavuz81@gmail.com>
Date: Fri, 13 Mar 2026 19:14:06 +0300
Message-ID: 
 <CAN55FZ1b1Jstrr-K7xcXY9z1ObDRxi48dAhwdHpTZn1C=S-jHA@mail.gmail.com>
Subject: Re: Speed up COPY FROM text/CSV parsing using SIMD
To: Greg Burd <greg@burd.me>
Cc: Nathan Bossart <nathandbossart@gmail.com>,
 Manni Wood <manni.wood@enterprisedb.com>,
	KAZAR Ayoub <ma_kazar@esi.dz>, Neil Conway <neil.conway@gmail.com>,
	Andrew Dunstan <andrew@dunslane.net>, Shinya Kato <shinya11.kato@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAN55FZ1b1Jstrr-K7xcXY9z1ObDRxi48dAhwdHpTZn1C%3DS-jHA%40mail.gmail.com>
Precedence: bulk

Hi Greg,

On Fri, 13 Mar 2026 at 18:29, Greg Burd <greg@burd.me> wrote:
>
> I've always been a fan of these kinds of optimization so I couldn't resis=
t reviewing, but I know you're ready to commit so I'll just check on some s=
ystems I have. :)

Thank you for the review!

> At first glance the implementation seems conservative, but correct and sa=
fe. Local testing on on Linux/FreeBSD x86_64, and Win11/aarch64/MSVC seem g=
ood. I also tried IllumOS/SPARCv9 and with some fixes (from another active =
thread) to the build system and it worked just fine too.  I'm sure the 10 p=
eople care will be thrilled. ;-

Yes, we can probably improve this further with heuristics, but for now
we wanted to avoid introducing any potential regressions.

> I also created a few tests (attached) to check boundary conditions, I mig=
ht add some along with the RISC-V work.

Thank you for the tests! I have checked them and the output is the
same on both v17 and master. Do you think it would make sense to add
them as regression tests?

--=20
Regards,
Nazir Bilal Yavuz
Microsoft