MIME-Version: 1.0
References: <20240707052030.r77hbdkid3mwksop@awork3.anarazel.de>
 <625384.1720329973@sss.pgh.pa.us> <e006b6a2-2f8e-4463-a58e-09cd51280432@dunslane.net>
 <20240708201649.qaqllje7vc7eyiix@awork3.anarazel.de> <a49418d3-83ea-42bf-a356-2a057839c2e0@dunslane.net>
 <20240708214421.fxunxj2i34faoxq3@awork3.anarazel.de> <CA+OCxowFXZR8r=FLK5LY2AcN_4Nq1U7k7jQOpSe0_gePCLPekw@mail.gmail.com>
 <68d948a3-704a-4a0e-a7c9-0591f4ade7ce@dunslane.net> <9b08e271-5ae9-4bf2-b328-9123fceb7b98@dunslane.net>
 <CA+OCxoxL4=C3ZNu-KtyJ6FTqhL=-eEizN++unGu3AUKEiejK-g@mail.gmail.com>
 <1732390.1720617925@sss.pgh.pa.us> <45d4c542-7b76-4ab5-92ba-0b4e220f9f6d@dunslane.net>
In-Reply-To: <45d4c542-7b76-4ab5-92ba-0b4e220f9f6d@dunslane.net>
From: Nazir Bilal Yavuz <byavuz81@gmail.com>
Date: Thu, 11 Jul 2024 11:59:57 +0300
Message-ID: <CAN55FZ1objLz3Vn5Afu4ojNESMQpxjxKcp2q18yrKF4eKMLENg@mail.gmail.com>
Subject: Re: tests fail on windows with default git settings
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Dave Page <dpage@pgadmin.org>, 
	Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAN55FZ1objLz3Vn5Afu4ojNESMQpxjxKcp2q18yrKF4eKMLENg%40mail.gmail.com>
Precedence: bulk

Hi,

On Wed, 10 Jul 2024 at 17:04, Andrew Dunstan <andrew@dunslane.net> wrote:
>
>
> On 2024-07-10 We 9:25 AM, Tom Lane wrote:
> > Dave Page <dpage@pgadmin.org> writes:
> >> On Wed, 10 Jul 2024 at 12:12, Andrew Dunstan <andrew@dunslane.net> wrote:
> >>> As I was looking at this I wondered if there might be anywhere else that
> >>> needed adjustment. One thing that occurred to me was that that maybe we
> >>> should replace the use of "-w" in pg_regress.c with this rather less
> >>> dangerous flag, so instead of ignoring any white space difference we would
> >>> only ignore line end differences. The use of "-w" apparently dates back to
> >>> 2009.
> >> That seems like a good improvement to me.
> > +1
> >
> >
>
>
> OK, done.

It looks like Postgres CI did not like this change. 'Windows - Server
2019, VS 2019 - Meson & ninja' [1] task started to fail after this
commit, there is one extra space at the end of line in regress test's
output.

[1] https://cirrus-ci.com/task/6753781205958656

-- 
Regards,
Nazir Bilal Yavuz
Microsoft