MIME-Version: 1.0
References: 
 <CAEoWx2mgTMAvXDi0AZVMeKys0owGa5tdQUJ0gonAjsdBOYMNkg@mail.gmail.com>
 <202512041120.t3l7vzgdlzhj@alvherre.pgsql>
In-Reply-To: <202512041120.t3l7vzgdlzhj@alvherre.pgsql>
From: Bilal Yavuz <byavuz81@gmail.com>
Date: Thu, 4 Dec 2025 16:04:07 +0300
Message-ID: 
 <CAN55FZ2M3J38q6PpPjuD-SjxiFDLn-80nR6Xj=kf4vU4h3rHgA@mail.gmail.com>
Subject: Re: Cleanup shadows variable warnings, round 1
To: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>
Cc: Chao Li <li.evan.chao@gmail.com>, Peter Smith <smithpb2250@gmail.com>,
	Peter Eisentraut <peter@eisentraut.org>,
	Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAN55FZ2M3J38q6PpPjuD-SjxiFDLn-80nR6Xj%3Dkf4vU4h3rHgA%40mail.gmail.com>
Precedence: bulk

Hi,

On Thu, 4 Dec 2025 at 14:21, =C3=81lvaro Herrera <alvherre@kurilemu.de> wro=
te:
>
> On 2025-Dec-04, Chao Li wrote:
>
> > The motivation is that CF=E2=80=99s CI currently fails on shadow-variab=
le warnings.
> > If you touch a file like a.c, and that file already has a legacy shadow=
ing
> > issue, CI will still fail your patch even if your changes are correct. =
Then
> > you=E2=80=99re forced to fix unrelated shadow-variable problems just to=
 get a clean
> > CI run. I=E2=80=99ve run into this myself, and it=E2=80=99s disruptive =
for both patch
> > authors and reviewers.
>
> Hmm, maybe that should be turned off.  It sounds seriously unhelpful.

To test that I created this CI run [1], which edits the brin.c file.
That file has a legacy shadowing issue but the CI did not fail. Could
you please show an example CI run?

[1] https://cirrus-ci.com/build/5444936843132928

--
Regards,
Nazir Bilal Yavuz
Microsoft