MIME-Version: 1.0
References: <20240512.155006.1316723460000187647.t-ishii@sranhm.sra.co.jp>
In-Reply-To: <20240512.155006.1316723460000187647.t-ishii@sranhm.sra.co.jp>
From: Nazir Bilal Yavuz <byavuz81@gmail.com>
Date: Sun, 12 May 2024 12:08:47 +0300
Message-ID: <CAN55FZ3QrZ2-yO_siWnNEEgEPshCXaSsZ1E1VVfxm6di-ybm-w@mail.gmail.com>
Subject: Re: CFbot does not recognize patch contents
To: Tatsuo Ishii <ishii@sraoss.co.jp>
Cc: pgsql-hackers@postgresql.org, Thomas Munro <thomas.munro@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAN55FZ3QrZ2-yO_siWnNEEgEPshCXaSsZ1E1VVfxm6di-ybm-w%40mail.gmail.com>
Precedence: bulk

Hi,

On Sun, 12 May 2024 at 09:50, Tatsuo Ishii <ishii@sraoss.co.jp> wrote:
>
> After sending out my v18 patches:
> https://www.postgresql.org/message-id/20240511.162307.2246647987352188848.t-ishii%40sranhm.sra.co.jp
>
> CFbot complains that the patch was broken:
> http://cfbot.cputube.org/patch_48_4460.log
>
> === Applying patches on top of PostgreSQL commit ID 31e8f4e619d9b5856fa2bd5713cb1e2e170a9c7d ===
> === applying patch ./v18-0001-Row-pattern-recognition-patch-for-raw-parser.patch
> gpatch: **** Only garbage was found in the patch input.
>
> The patch was generated by git-format-patch (same as previous
> patches).  I failed to find any patch format problem in the
> patch. Does anybody know what's wrong here?

I am able to apply all your patches. I found that a similar thing
happened before [0] and I guess your case is similar. Adding Thomas to
CC, he may be able to help more.

Nitpick: There is a trailing space warning while applying one of your patches:
Applying: Row pattern recognition patch (docs).
.git/rebase-apply/patch:81: trailing whitespace.
 company  |   tdate    | price | first_value | max | count

[0] postgr.es/m/CA%2BhUKGLiY1e%2B1%3DpB7hXJOyGj1dJOfgde%2BHmiSnv3gDKayUFJMA%40mail.gmail.com

-- 
Regards,
Nazir Bilal Yavuz
Microsoft