MIME-Version: 1.0
References: <DFYFWM053WHS.10K8ZPJ605UFK@jeltef.nl> <luhx26gz3tiqkndldbobukt4zeaeu2ppd5qgsibf6hknhq6d7e@kngeuarhk5dg>
 <DFZGDORXS9MU.242AFAEFZ6H76@jeltef.nl>
In-Reply-To: <DFZGDORXS9MU.242AFAEFZ6H76@jeltef.nl>
From: Nazir Bilal Yavuz <byavuz81@gmail.com>
Date: Tue, 3 Feb 2026 13:20:26 +0300
Message-ID: <CAN55FZ3w-3z=js-3We78P41heKCY1aOMsUz3p7UrQa7amGWL7g@mail.gmail.com>
Subject: Re: meson: Make test output much more useful on failure (both in CI
 and locally)
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: Andres Freund <andres@anarazel.de>, 
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CAN55FZ3w-3z%3Djs-3We78P41heKCY1aOMsUz3p7UrQa7amGWL7g%40mail.gmail.com>
Precedence: bulk

Hi,

Thank you for working on this! I think this is a nice improvement.

On Tue, 27 Jan 2026 at 17:48, Jelte Fennema-Nio <postgres@jeltef.nl> wrote:
>
> On Mon Jan 26, 2026 at 5:42 PM CET, Andres Freund wrote:
> > I agree that what we currently do is pretty unhelpful.
>
> Attached is v2, which I think fixes all the issues that you mentioned.

v2-0001:

This doesn't really read the first 80 lines of the combined diff.
Lines with more than 1023 characters will be counted and printed as
multiple lines. I don't think this is a problem but clearing this
would be helpful. Other than that, it looks good to me.

v2-0002:

I am just curious if test failure can cause file descriptors not being
properly closed and then the IPC::Run:run() call will hang
indefinitely like the pg_ctl case. Other than that, it looks good to
me.

v2-0003 and v2-0004 look good to me.

-- 
Regards,
Nazir Bilal Yavuz
Microsoft