public inbox for [email protected]  

help / color / mirror / Atom feed

From: John Naylor <[email protected]>
To: Álvaro Herrera <[email protected]>
Cc: David Rowley <[email protected]>
Cc: Mario González Troncoso <[email protected]>
Cc: Chao Li <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: Jacob Brazeal <[email protected]>
Subject: Re: [PATCH} Move instrumentation structs
Date: Tue, 13 Jan 2026 18:54:03 +0700
Message-ID: <CANWCAZYBNjR6vvPuBBVT37P3yEUiGoY=KFSPo740QVoyk8QzUQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAApHDvqPmpa53jcTmfU8arFFm7=hB5cFoXX5dcUH=1qV0tRFHA@mail.gmail.com>
	<[email protected]>

On Tue, Jan 13, 2026 at 6:38 PM Álvaro Herrera <[email protected]> wrote:
>
> On 2026-Jan-13, David Rowley wrote:
>
> > There's a bit of conflicting opinion going on here with the changes
> > made in 128897b101e0.

> Sounds about right, though I think we can shave some words off that.
> How about
>
>     int64       maxSpace;       /* maximum amount of space occupied among sort
>                                  * of groups, either in-memory or on-disk */
>     bool        isMaxSpaceDisk; /* true when maxSpace tracks on-disk space, false
>                                  * means in-memory */
> ?
>
> (CCed Jacob as author and John as committer of that change, in case they
> care to comment.)

Hmm, yeah, that commit wasn't quite enough to make that phrase clear,
but I don't remember the interpretation.

--
John Naylor
Amazon Web Services

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH} Move instrumentation structs
  In-Reply-To: <CANWCAZYBNjR6vvPuBBVT37P3yEUiGoY=KFSPo740QVoyk8QzUQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox