MIME-Version: 1.0
References: <adJn3nBX13YYRBJP@momjian.us>
 <202604051405.sxedzcgzky3n@alvherre.pgsql>
 <xgwkagej6rzkxg235ol4vzq3dljvaumzk3lhfecld4hogl4od5@mq6jaccjoxvz>
 <582789.1775401852@sss.pgh.pa.us> <adO3I7qlDPEbGHrI@momjian.us>
 <adPDZVFW881g6DU-@momjian.us>
In-Reply-To: <adPDZVFW881g6DU-@momjian.us>
From: John Naylor <johncnaylorls@gmail.com>
Date: Mon, 6 Apr 2026 21:47:32 +0700
Message-ID: 
 <CANWCAZYtUp0y8A0Viz05sJQXsaFj8DqHLnAvY8-jsMj=YWoxXw@mail.gmail.com>
Subject: Re: PG 19 release notes and authors
To: Bruce Momjian <bruce@momjian.us>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>,
	=?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
	Peter Geoghegan <pg@bowt.ie>, Andrey Borodin <x4mmm@yandex-team.ru>,
	PostgreSQL-development <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CANWCAZYtUp0y8A0Viz05sJQXsaFj8DqHLnAvY8-jsMj%3DYWoxXw%40mail.gmail.com>
Precedence: bulk

On Mon, Apr 6, 2026 at 9:30=E2=80=AFPM Bruce Momjian <bruce@momjian.us> wro=
te:
> I now realize the Commit Message Guidance used during PG 19 was unclear;
> it was:
>
>         Used to indicate the patch authors.  "Co-authored-by:" is used by
>         committers when they want to give full credit to the named indivi=
duals,
>         but also indicate that they made significant changes.
>
> I doesn't really say we are giving credit to "Author" individuals but
> list committers as co-authors with no credit, so that bad wording is on
> me.  It should have said:
>
>         Used to indicate the patch authors.  "Co-authored-by:" is to list
>         committers when they want to give full credit to the "Author"
>         individuals, but also indicate that they made significant changes=
.

That's not how I interpreted it at all, and after seeing commits with
both "Author" and "Co-authored-by" I am equally confused as to how
people are interpreting it.

> I think having "Co-authored-by:" mean one thing when "Author" appears
> and a different thing when "Author" is missing is too confusing.

My take is that the co-author tag has backfired and made things less
clear. If we are using it inconsistently, then it doesn't convey any
useful information. I'd actually rather just use "Author" exclusively
and if there is some further detail that needs to be conveyed, it can
be in the message body.

--
John Naylor
Amazon Web Services