MIME-Version: 1.0
References: <20250911054220.3784-1-root@ip-172-31-36-228.ec2.internal>
 <CANWCAZYZQw-nzTXbx3Bk332VtY9_D7ksDsuMZ0A-iDZ53yG7Ng@mail.gmail.com>
 <CAK64mnfeWLBRbMfnOsag0vGTDnT84KJzpuei40nG0OHyw4SESw@mail.gmail.com>
 <CANWCAZa1b2rcvoK657SmcKwh2P2cgASQ1D-0JPj5d3LbfaAVgA@mail.gmail.com>
 <CAK64mneN20+sW5WhV+r7hMVo4Rd0z11B6=3L039rWMt1wK3nPg@mail.gmail.com>
 <CANWCAZZuS3sNgLRo8Z4AM=uY4zTmz=dH5D4Z9xV6K0CEuJ8Hdw@mail.gmail.com>
 <CAK64mnejn9AZMYz03e7HX8Uui35PihUuOy=b+iBG=YtRKx0Log@mail.gmail.com>
In-Reply-To: 
 <CAK64mnejn9AZMYz03e7HX8Uui35PihUuOy=b+iBG=YtRKx0Log@mail.gmail.com>
From: John Naylor <johncnaylorls@gmail.com>
Date: Wed, 29 Oct 2025 09:50:45 +0700
Message-ID: 
 <CANWCAZZ_0AQMk1HgHXHX+JaeBfy_4kzwHgTdqMptDA7zM+nm+Q@mail.gmail.com>
Subject: Re: Proposal for enabling auto-vectorization for checksum
 calculations
To: Andrew Kim <tenistarkim@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org,
	Oleg Tselebrovskiy <o.tselebrovskiy@postgrespro.ru>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CANWCAZZ_0AQMk1HgHXHX%2BJaeBfy_4kzwHgTdqMptDA7zM%2Bnm%2BQ%40mail.gmail.com>
Precedence: bulk

On Fri, Oct 24, 2025 at 2:49=E2=80=AFPM Andrew Kim <tenistarkim@gmail.com> =
wrote:
> The function signatures (pg_checksum_block, pg_checksum_page) remain
> identical, and checksum_impl.h still contains the complete
> implementation that external programs can include. The runtime
> dispatch only affects internal PostgreSQL usage.

I don't quite understand the architecture here -- all
platform-specific definitions were put in the "checksum_impl.h"
header. My thinking was that checksum.c would have all that, with thin
wrappers around the functions included from that header.

--
John Naylor
Amazon Web Services