MIME-Version: 1.0
References: 
 <CAAZLFmSOD8R7tZjRLZsmpKtJLoqjgawAaM-Pne1j8B_Q2aQK8w@mail.gmail.com>
 <CANWCAZbHJmmais=W-4BmP3ZTdGSUSxKMV07idje3CfKtJirxxw@mail.gmail.com>
In-Reply-To: 
 <CANWCAZbHJmmais=W-4BmP3ZTdGSUSxKMV07idje3CfKtJirxxw@mail.gmail.com>
From: John Naylor <johncnaylorls@gmail.com>
Date: Tue, 24 Mar 2026 17:30:14 +0700
Message-ID: 
 <CANWCAZZbjetZPb8XhCvNRNo8Ji_qaowq1VT4hhyoLiBAGaJo3w@mail.gmail.com>
Subject: Re: BUG: test_ginpostinglist second itemptr check is a no-op due to
 copy-paste error
To: Jianghua Yang <yjhjstz@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CANWCAZZbjetZPb8XhCvNRNo8Ji_qaowq1VT4hhyoLiBAGaJo3w%40mail.gmail.com>
Precedence: bulk

On Tue, Mar 24, 2026 at 8:59=E2=80=AFAM John Naylor <johncnaylorls@gmail.co=
m> wrote:
>
> On Tue, Mar 24, 2026 at 8:45=E2=80=AFAM Jianghua Yang <yjhjstz@gmail.com>=
 wrote:
> >   The attached patch fixes the second check to compare orig_itemptrs[1]
> >   with decoded_itemptrs[1] and reports (blk, off) as the expected
> >   value in the error message.
>
> Seems right to me, thanks for the patch. I'll take care of this.

This is done. It seems unlikely that this test would need to be
changed in back branches, but I went ahead and backpatched it anyway
just in case.

--
John Naylor
Amazon Web Services