Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vLDdk-008f47-1L for pgsql-hackers@arkaria.postgresql.org; Tue, 18 Nov 2025 04:48:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vLDdh-003vtJ-2i for pgsql-hackers@arkaria.postgresql.org; Tue, 18 Nov 2025 04:48:26 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vLDdh-003vtB-1p for pgsql-hackers@lists.postgresql.org; Tue, 18 Nov 2025 04:48:25 +0000 Received: from mail-qt1-x843.google.com ([2607:f8b0:4864:20::843]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vLDdf-0006bC-0V for pgsql-hackers@lists.postgresql.org; Tue, 18 Nov 2025 04:48:24 +0000 Received: by mail-qt1-x843.google.com with SMTP id d75a77b69052e-4edaf8773c4so51176781cf.1 for ; Mon, 17 Nov 2025 20:48:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763441303; x=1764046103; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4K0Y2Qra+T4VKcLHnqi1VGI5xFcVOhLDbuMAe55bEaM=; b=GC8yLmrVYEnAU+eqmXLzLIu++oNeZtMI4+u6T0ionMkmA2QzZ4GmOVwwDHjluu/NmI g8zbfYnPF/yIAis9j5obCgV7DrF9iAV3vonTmRlSDuwXEus3P2KrRPSxyUgtoAIgA8ls /QGNsfuxTGP60aj+S/39CGE75ZtYqup98ehbG0sJ+CuOcqqHa/9TwD0UvrPIGkwFlb5d 4EsGDE9fYtj8F8nMS3LiharHXtJrcaSm04sbn1ZQ0xcm5CaaaAd7YAfAx1yxQHudlMed 4CoV3ZJXWEQ0bV5qoY4tvp+6wgcQACQIC7iC+Y5zbt0hvDOv0SNga19DNj95Y+HljsTL o06w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763441303; x=1764046103; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4K0Y2Qra+T4VKcLHnqi1VGI5xFcVOhLDbuMAe55bEaM=; b=dG7jWdtIIPgLNA6Jay7pfiPYMkTCF4ZUlZ4Grsel2GRRIgbx4hWNeMuS+yKJENiyML VWqbKOm8OjLkuNuBMRJ+UjhCKRDmgurYv0N6EQEbElGy/nwju5CdzOJKhc9B4jhJKaye ucHquD16Mg/Z7d1uiQBy8a6KGgTZKJ03Lsu+BJwgmhnJgSgZaLBFYCc/wrYtplQ1gVVw n8L3xnZNTzE2uJY7oV2MgGv/PXW4k84O4cIFYemP2/NV+70SpNcRWRYBM2sFVVIZTc93 yKlnJC/hCKTvHTjR9szmghxwH4bfNhmOYs3KpLKR/FMeLW36i9rmlk7NQVnKhrqLbmdA ZR3w== X-Gm-Message-State: AOJu0Yz3/IZ+0hRuceCL4juyHwmZwjz7EREfeathdOwqthFFKuu4WMpV sDURDh6bzpIFmqSa3v5OhbBs7mvyR2a0Pv5ieo700a/PWSNxpta1hDCHff+gARWL580hukQxBD8 3HiyWsyrDKiww5u3bTKCuiavLNMBK1vY= X-Gm-Gg: ASbGnculgrUXzA/qp4txNQUL37/HIcrgEGH7SJWa0bZnYQeBsOBzr4KtMD6/4J2nO/N 92sG/D29a7YZoOyDu/kVroyDxwoU9OvHz3DZXtcbcBcQRfR/S4SZbNmVRTXU+8aKlAQ+2xlrcuw I3l2h+IkMiVDx6Wqc4cR0TAm1xYCx/uwJoEH7quvPsQBntpm2dTEjZwrzgUsVh6HoMt58KqJsy8 zfZn3gXEyTvzyMsub2YLLKlGfV0OsQh6fPAjHlkMJDQR+8ZNldiYscQTtVeDsh803mTor7CjVjh bjAy82auiE2Mf/0lZop/zH7EVXPA8RmgXOiivdjABCOacPD9gDUGnayuLoTpOx2LRbFx2ATp9WF plkeU X-Google-Smtp-Source: AGHT+IG2wZL1pV1JmvVucVGCe33OJ88/6HHhknGDeTD5Uk0l0ykLaIS/l+ar+UO8F3BEg+IKItnyZoXdANNwKC8LYLE= X-Received: by 2002:ac8:58d1:0:b0:4ee:1f8b:5444 with SMTP id d75a77b69052e-4ee1f8b97c0mr97604031cf.70.1763441303070; Mon, 17 Nov 2025 20:48:23 -0800 (PST) MIME-Version: 1.0 References: <20250911054220.3784-1-root@ip-172-31-36-228.ec2.internal> In-Reply-To: From: John Naylor Date: Tue, 18 Nov 2025 11:48:12 +0700 X-Gm-Features: AWmQ_bm4tsV1DV4035ftnI9FMeegglnW0iLVfIYXny2yhMKzfoLk1lavhETAu1A Message-ID: Subject: Re: Proposal for enabling auto-vectorization for checksum calculations To: Andrew Kim Cc: pgsql-hackers@lists.postgresql.org, Oleg Tselebrovskiy Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Nov 18, 2025 at 10:32=E2=80=AFAM Andrew Kim = wrote: > I've double-checked everything after applying the v9 checksum patches > and updating pg_filedump accordingly. > Following your suggestion, I removed the checksum_impl.h include and > the Assert redefinition, keeping only the port/checksum.h include. > build compiles cleanly with the new architecture, and pg_filedump > functions correctly with the AVX2 optimizations. > If you agree with this approach, I'd like to prepare a patch for > upstream submission. Thanks, but there is no action required now. I mentioned some observations, and I'm going to experiment a bit further. Also, it's way too early to be suggesting changes to other projects, since we haven't committed anything yet. Even things committed can occasionally be reverted before beta 1 anyway. --=20 John Naylor Amazon Web Services