MIME-Version: 1.0
References: <1936493cc38.68cb2ef27266.7456585136086197135@zohocorp.com> <CANWCAZYJe4vya4taNFdqK2dx6q3VmyxyL7V+8DBy62YnaQUeiA@mail.gmail.com>
In-Reply-To: <CANWCAZYJe4vya4taNFdqK2dx6q3VmyxyL7V+8DBy62YnaQUeiA@mail.gmail.com>
From: John Naylor <johncnaylorls@gmail.com>
Date: Thu, 5 Dec 2024 08:46:33 +0700
Message-ID: <CANWCAZZgVMvByZA1r9mpPsHYnGrvX=HJR20H+5rbs3AnwvbfFA@mail.gmail.com>
Subject: Re: [Bug] Heap Use After Free in parallel_vacuum_reset_dead_items Function
To: Vallimaharajan G <vallimaharajan.gs@zohocorp.com>
Cc: "zlabs-cstore@zohocorp.com" <zlabs-cstore@zohocorp.com>, 
	pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CANWCAZZgVMvByZA1r9mpPsHYnGrvX%3DHJR20H%2B5rbs3AnwvbfFA%40mail.gmail.com>
Precedence: bulk

On Tue, Nov 26, 2024 at 4:53=E2=80=AFPM John Naylor <johncnaylorls@gmail.co=
m> wrote:
> Thanks for the report! I don't see any immediate evidence of deleterious =
effects, but it's still sloppy. To reduce risk going forward, I think we sh=
ould always access this pointer via the struct rather than a separate copy,=
 quick attempt attached.

[removing -bugs]

I looked again and changed a few more places for consistency, and committed=
.

--=20
John Naylor
Amazon Web Services