public inbox for [email protected]  

help / color / mirror / Atom feed

From: John Naylor <[email protected]>
To: Heikki Linnakangas <[email protected]>
Cc: David Geier <[email protected]>
Cc: Matthias van de Meent <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: Reduce build times of pg_trgm GIN indexes
Date: Wed, 8 Apr 2026 09:15:38 +0700
Message-ID: <CANWCAZa-AUG=aK7UGGa+NY0sZ2o09Ko=z_N-irkC7Ura_c3uJg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAEze2WiUL9idZBbuUN+MuWqr6DcPr_-C91E9MTx=H62Xx5fHaQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On Tue, Apr 7, 2026 at 6:27 PM Heikki Linnakangas <[email protected]> wrote:
> But the comments on the pg_cmp functions say:
>
> >  * NB: If the comparator function is inlined, some compilers may produce
> >  * worse code with these helper functions than with code with the
> >  * following form:
> >  *
> >  *     if (a < b)
> >  *         return -1;
> >  *     if (a > b)
> >  *         return 1;
> >  *     return 0;
> >  *
>
> So, uh, is that really a universal improvement? Is that comment about
> producing worse code outdated?

No, it's quite recent:

https://www.postgresql.org/message-id/20240212230423.GA3519%40nathanxps13

--
John Naylor
Amazon Web Services

view thread (31+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Reduce build times of pg_trgm GIN indexes
  In-Reply-To: <CANWCAZa-AUG=aK7UGGa+NY0sZ2o09Ko=z_N-irkC7Ura_c3uJg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox