MIME-Version: 1.0
References: 
 <CAJ7c6TMk10rF_LiMz6j9rRy1rqk-5s+wBPuBefLix4cY+-4s1w@mail.gmail.com>
 <932CBCA0-FF4B-406E-9296-1B8A63C3EB49@yandex-team.ru>
 <CAJ7c6TPoPMfGwVuM14T7KuWVcRaoE3-nd3goLoE5zss4JzAExw@mail.gmail.com>
 <acOWBAZpGw6XLThN@paquier.xyz>
In-Reply-To: <acOWBAZpGw6XLThN@paquier.xyz>
From: John Naylor <johncnaylorls@gmail.com>
Date: Tue, 7 Apr 2026 13:51:35 +0700
Message-ID: 
 <CANWCAZaBx0vD5uj8rX6C2n=CV_mFV_uK+spkV5G9Ak_-AhY9oQ@mail.gmail.com>
Subject: Re: [PATCH] Simplify SortSupport implementation for macaddr
To: Michael Paquier <michael@paquier.xyz>
Cc: Aleksander Alekseev <aleksander@tigerdata.com>,
	PostgreSQL Development <pgsql-hackers@postgresql.org>,
 Andrey Borodin <x4mmm@yandex-team.ru>,
	Tom Lane <tgl@sss.pgh.pa.us>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CANWCAZaBx0vD5uj8rX6C2n%3DCV_mFV_uK%2BspkV5G9Ak_-AhY9oQ%40mail.gmail.com>
Precedence: bulk

On Wed, Mar 25, 2026 at 3:01=E2=80=AFPM Michael Paquier <michael@paquier.xy=
z> wrote:
>
> On Mon, Mar 09, 2026 at 04:08:06PM +0300, Aleksander Alekseev wrote:
> >> 1. The assignment ssup->ssup_extra =3D NULL can be removed. The
> >>    SortSupport struct is zeroed before the callback is called (see
> >>    sortsupport.h). There are about 22 similar assignments elsewhere;
> >>    it does not seem to be established practice, many other places have
> >>    no such assignment.
> >
> > Agree. I removed this assignment in 0001 and added 0002 that removes
> > if for the rest of *_sortsupport() functions.
>
> Sounds sensible to get rid of the estimation with the Datum size
> requirement and never give up with the abbreviated key sort, as done
> in 0001.  I'd leave the code touched by 0002 remain as-is.

I've committed v2-0001, thanks Aleksander! Without 0002, 0001 made
this code inconsistent with the tree by removing the assignment, so I
left it as in master.

--
John Naylor
Amazon Web Services