MIME-Version: 1.0
References: <20260324203430.411331c59ca462457ec0aa8b@sraoss.co.jp>
 <CANWCAZYdyQzCoAiq9kybHT2RcnC1CgrxbCpyxeV3+KZn2xj2UA@mail.gmail.com>
 <20260325131548.4c9a0c8d05a422021b1ba76c@sraoss.co.jp>
 <CANWCAZYjDSsvC6M6pas26ffbj-TZmXOHHC1-DwRM2LFa+qr3GQ@mail.gmail.com>
 <acXAAbIp9tfsvHxy@paquier.xyz>
In-Reply-To: <acXAAbIp9tfsvHxy@paquier.xyz>
From: John Naylor <johncnaylorls@gmail.com>
Date: Fri, 27 Mar 2026 07:45:37 +0700
Message-ID: 
 <CANWCAZaZeX0omWNh_ZbD_JVujzYQdRUW8UZOQ4dWh9Sg7OcAow@mail.gmail.com>
Subject: Re: Adjust error message for CREATE STATISTICS to account for
 expressions
To: Michael Paquier <michael@paquier.xyz>
Cc: Yugo Nagata <nagata@sraoss.co.jp>,
 Pgsql Hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CANWCAZaZeX0omWNh_ZbD_JVujzYQdRUW8UZOQ4dWh9Sg7OcAow%40mail.gmail.com>
Precedence: bulk

On Fri, Mar 27, 2026 at 6:23=E2=80=AFAM Michael Paquier <michael@paquier.xy=
z> wrote:
> -    errmsg("extended statistics require at least 2 columns")));
> +    errmsg("extended statistics are not supported on a single column")))=
;
>
> Now our documentation also tells that the former message is not the
> preferred project style (full sentences usually avoided in primary
> messages):
> https://www.postgresql.org/docs/devel/error-style-guide.html#ERROR-STYLE-=
GUIDE-GRAMMAR-PUNCTUATION

My reading of that is that hints/details need to be complete
sentences, and primary messages don't need to be. If the obvious way
to write primary message is with a complete sentence, I would say
that's fine, but I don't have a lot of context here.

> Perhaps something like "could not create extended statistics" with a
> hint describing the cause would be better..  Full sentences usually
> apply to errdetails or errhints.  If we're on it, we could just as
> well improve the whole thing, I guess?

I don't feel strongly either way, so in that case I would default to
not changing to errdetail. Looking elsewhere in this file, however, I
do see some messages with "cannot do X because ....", and I'd be more
motivated to turn those "because" phrases into errdetails.

--=20
John Naylor
Amazon Web Services