MIME-Version: 1.0
References: 
 <CANWCAZYzx7a7E9AY16Jt_U3+GVKDADfgApZ-42SYNiig8dTnFA@mail.gmail.com>
 <CANWCAZbsx5VY-F5RVvZ5H1abBWcinMY90gNra6EbdGS1CTx=7g@mail.gmail.com>
 <CANWCAZaN8kW6o7Ymc_jzPO_Z5SqekQTTNra3xTGYTH+cjrVp8g@mail.gmail.com>
 <269A8FB9-6D43-43CF-A6FE-52D28CBDB8A9@Outlook.com>
 <CANWCAZZiMGj6QuHfyBPv9at7xn23NPAz4nit=G6fr26V+h8MKg@mail.gmail.com>
 <F7935986-4E3D-477C-B45C-878420B45C0D@gmail.com>
 <CANWCAZaKRzsYPn9YWRR8g5dkX-ep_jgyUb4r3KFekK5ZTNo7ew@mail.gmail.com>
 <606C775A-4C1A-482B-BE7D-2E7A46AE14B9@gmail.com>
 <CANWCAZaBeDPfF0sCdSssRXv6nBZeRP8Z=OO1731zsoUC58U5_Q@mail.gmail.com>
 <F7D64692-F979-4661-B91C-8A1FF09F69BD@gmail.com>
 <9D3D4647-868B-4562-B382-D201478AD67B@gmail.com>
 <CANWCAZZo5rgE4+NYYES1hLN9PvonXMH=K3Z7b0TKcCBNOAjaag@mail.gmail.com>
 <54659731-2232-4E74-9533-D136D01B153F@gmail.com>
 <CANWCAZYur4VDbx9zkpFM3mM4-Hj4_Vt1t=Z4TPhK7+3=T6BMOA@mail.gmail.com>
 <tencent_6EB1CE2270AFA3DD4164A5D2@qq.com>
 <CANWCAZYBgHCpS-w5E8+wJpfhwLK88Kys-5ukSta2gj4BRPiTSg@mail.gmail.com>
 <tencent_1565D02652E0DC26675AABE2@qq.com>
 <tencent_D9FB41A25D4A685F6176ED4A4A804C06DE06@qq.com>
 <CANWCAZZA_AqWy7xw20O=jWG+t0Cy4rUnvs1RaAABvSp3iLnGhg@mail.gmail.com>
 <tencent_0A6A072C7636A1238520B50E29D332627808@qq.com>
 <CANWCAZaWV09=HdiF9mm7CBggFvxGkkHhhkSqyFoochQzW=RxAA@mail.gmail.com>
 <CANWCAZZuQPMAPoCUQo7E2v2Zk5z9T=8bE=VGpC8_TYG3aomGyQ@mail.gmail.com>
 <tencent_9748E2B51D64D949856216A6D59EA6BCC80A@qq.com>
 <CANWCAZacXFMeG=afHF+3rxuyr3=0UcdNgxO8wTZ58fOzvyhwNw@mail.gmail.com>
 <tencent_49E3F11E74D8A584A2144ED532A490CBC40A@qq.com>
 <CANWCAZZzXHoDpCx394OAhu0ppW_OanbJzYifVwuALeNMhmF8TA@mail.gmail.com>
 <tencent_1FF6C288DAB8947599693C9B833F3BB2D007@qq.com>
In-Reply-To: <tencent_1FF6C288DAB8947599693C9B833F3BB2D007@qq.com>
From: John Naylor <johncnaylorls@gmail.com>
Date: Wed, 29 Apr 2026 16:24:50 +0700
Message-ID: 
 <CANWCAZaaGcp6OQyK9WuB3V9Lp5xctNB3WNWiqo+TopUKvJDbLQ@mail.gmail.com>
Subject: Re: tuple radix sort
To: cca5507 <cca5507@qq.com>
Cc: zengman <zengman@halodbtech.com>,
	pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CANWCAZaaGcp6OQyK9WuB3V9Lp5xctNB3WNWiqo%2BTopUKvJDbLQ%40mail.gmail.com>
Precedence: bulk

On Wed, Apr 8, 2026 at 3:20=E2=80=AFPM cca5507 <cca5507@qq.com> wrote:
>
> > I also thought we should change this cast:
> >
> >         if (ssup->comparator =3D=3D ssup_datum_signed_cmp)
> >         {
> > -               norm_datum1 =3D orig + ((uint64) PG_INT64_MAX) + 1;
> > +               norm_datum1 =3D orig + (Int64GetDatum(PG_INT64_MAX)) + =
1;
> >         }
> >
> > Upthread you mention something else about treating Datum as an
> > integer, but I'm not sure if this is what you meant since you didn't
> > say. If you have concrete suggestions, feel free to share them.
>
> I think we can keep it as is now.

It's harmless, but see commit ff89e182d.

I included the assert along with the above and some small cosmetic
fixes I've been saving.

--
John Naylor
Amazon Web Services