MIME-Version: 1.0
References: <tencent_6B29EC4570E6F0C659B4EAA7@qq.com>
In-Reply-To: <tencent_6B29EC4570E6F0C659B4EAA7@qq.com>
From: John Naylor <johncnaylorls@gmail.com>
Date: Wed, 25 Mar 2026 16:51:26 +0700
Message-ID: 
 <CANWCAZahqjM9_XVRXpV=M9Y7fDiywUFrXUYpBebvxQxdYj+NSA@mail.gmail.com>
Subject: Re: [PATCH] Precompute string lengths in PerformRadiusTransaction
To: zengman <zengman@halodbtech.com>
Cc: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CANWCAZahqjM9_XVRXpV%3DM9Y7fDiywUFrXUYpBebvxQxdYj%2BNSA%40mail.gmail.com>
Precedence: bulk

On Mon, Jan 5, 2026 at 9:36=E2=80=AFPM zengman <zengman@halodbtech.com> wro=
te:
> I noticed that the `PerformRadiusTransaction` function is invoked in a lo=
op,
> and the function itself contains internal loops that repeatedly call strl=
en() on the 'passwd' and 'secret' strings.
> While the optimization gain may be minimal, I still think it=E2=80=99s wo=
rth making the change =E2=80=94
> we can precompute the lengths of these two strings at the start of the fu=
nction to eliminate redundant strlen() calls.

Shortly after you posted this, it was decided that we're going to
remove this method entirely:

https://wiki.postgresql.org/wiki/RADIUS

--=20
John Naylor
Amazon Web Services