Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vfX9U-002b5w-10 for pgsql-hackers@arkaria.postgresql.org; Tue, 13 Jan 2026 05:41:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vfX9T-0030HK-1N for pgsql-hackers@arkaria.postgresql.org; Tue, 13 Jan 2026 05:41:11 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vfX9T-0030HC-0P for pgsql-hackers@lists.postgresql.org; Tue, 13 Jan 2026 05:41:11 +0000 Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vfX9Q-00096R-39 for pgsql-hackers@lists.postgresql.org; Tue, 13 Jan 2026 05:41:10 +0000 Received: by mail-qt1-x841.google.com with SMTP id d75a77b69052e-4f1aecac2c9so76126091cf.1 for ; Mon, 12 Jan 2026 21:41:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768282868; x=1768887668; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=A0zQ6GDimQAS12akDwNlNMxctRTDwVj7SKebaYScz1c=; b=i5jQ+ZsWk5O3BGcK6wT6ulgGijYhgHn+7XZHIJWMpOejOlqONiBk3dplXJVsw1JJ1P 1qb+dd2o76GNGFfPRF+sSCn2YPgTexx1dXaF3pkBw5vRNOb0bCXEq7ctKnn63y/gaTpy MBoeIsEJdRaws2xU3ma7wr2p4w5EPHnrxWx5kOvgvSOkd8YhwevVUCQR+szMZVUr8Soz zdnx800HoCP2cliekx2CTkj4EiYibHpgZs1uTDGP+fSo7SKSUfAsLZ2yeV6hxkF02g4p bb6HbG/oUKyLXFsTOW6dHJjaS2SM62eIVDEM82bETUJ3ABe6cZJ+awflLFVzcj2ZCYCu GsEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768282868; x=1768887668; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=A0zQ6GDimQAS12akDwNlNMxctRTDwVj7SKebaYScz1c=; b=S2nOk0J33x51gio6uHgaYwkdCmC6TNNUUqv1nqT4WMtnsud6frfZiZIFSH3XV5+geV X9jQ9Wz63vCCkw05FQehfBqwb8+ArjalUpgXhGkfWcYa/IwkrncsDWVTaG3n83oznZtD 8fiUCAIcm5RyrexnwvGqO4+OcIgIaxpuQ86HoGl73iTGhl8EN2vVNMOl9EkM3g5E6Kcz Zj3A3JFr7/oM7AAQlow79ZbyEN+OQCUXIwGTjiIZ+EzgVXa3iJQxPCF7UFOY+TI8KYUj SmyFXII7M2eyl4UbgeCrt0Wqd+ynqKPs36DXL2gOAg5pb8ujl5D4l2MpYGGrIB8eZGoH Klnw== X-Forwarded-Encrypted: i=1; AJvYcCWwSmQ10D35dgfuLT/aOJN32dUmEimawTP+m+bBvOKBP282ShsoFtMmTsOy5zqbD000XYXHpS2o8g17viHh@lists.postgresql.org X-Gm-Message-State: AOJu0YwnDHt1OuAkRLscLv6PXjsQY2U7brl3KRhyFeSWqTvn4VdV2iq2 o+U+YqNJgJLDv3FFls+BKI9oXp1Wsk9YqbevJWLRPJfvJI7BmhRqUbIeWFCqTsuF8kbCyFMizHV a16qCbj0J8IjKrCZ33JL1A3PSISllwqg= X-Gm-Gg: AY/fxX6jfvj1Elv0Obk0Pj75OBD1o25yXxyAzhFQ2ivg8ZCwOs4gYkVi+2Gib0o2aM0 1KOhApBJV0P960x77vScQroiR2tg/bL2durkBEEGoPf67uwdRa3MahiF6y00QUI5xTAffJNNDaV sDCqtaDJG6zQWvqw4y3J3roDhH+keL5i7its8orQLQ67hTVmC11TLFrHKcsE69kv23wKVnpxBA4 ApIN9YUz03Lcf8kjGwPJOSsag1kIykUxaJWYYoQpAHEtB511wfcNUlRBDFd9USdBAQlYcU5s5Pm c2Rn90E19MjZt0qLlLOw6j/RtIHDD3GiaLFwKOm5PrOxZ0CpDj60cMuCCOkWzamNq99OZ2qE2xo LCgBoLdhZueGFESY= X-Google-Smtp-Source: AGHT+IENANvX5x0MXyLNI9pSRWRJw52bBmIUjnGlwzz0ccy9ZYdHfxE+bvx1lWBmVwCN/KlPU6exxO9e4wB9A1mw1YM= X-Received: by 2002:a05:622a:15cd:b0:4ec:f260:57bc with SMTP id d75a77b69052e-501397a2896mr19147321cf.10.1768282868472; Mon, 12 Jan 2026 21:41:08 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: John Naylor Date: Tue, 13 Jan 2026 12:40:57 +0700 X-Gm-Features: AZwV_Qji7wJ0C0d8c9H5JDwEFjYEe_4QEo3w4zBzgN5h-GdbB3uDVYupgXsuVAU Message-ID: Subject: Re: Correct comment wording in extension.c To: Chao Li Cc: li carol , albert tan , "pgsql-hackers@lists.postgresql.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sun, Jan 11, 2026 at 11:58=E2=80=AFAM Chao Li w= rote: > v4-0001 looks good to me. When I say I'm going to commit "unless/barring", no response is necessary unless there is a problem. > I just went through extension.c and got a few more comment improvements. = I put them in v5-0002, please take a look. - * for them therefore uses about O(N^2) time when there are N versions of + * for them therefore uses O(N^2) time when there are N versions of - /* store the OID of the namespace to-be-changed */ + /* store the OID of the namespace to be changed */ Please read these responses to you from last week: https://www.postgresql.org/message-id/1909358.1767854695%40sss.pgh.pa.us https://www.postgresql.org/message-id/7k27ut6kugt2mizo5cy5wplbbrz4ccbkxvsc2= iqu5yde344iya%40dxktdjw6uvi2 I've pushed v4. -- John Naylor Amazon Web Services