MIME-Version: 1.0
References: <CANWCAZbgEUFw7LuYSVeJ=Tj98R5HoOB1Ffeqk3aLvbw5rU5NTw@mail.gmail.com>
 <CAN4CZFNpt2tsysM5j8GvhOLqU2fKiPEGW7xGJ987_Avwk7-7ag@mail.gmail.com>
 <CANWCAZbzmbCmKiCCWNGuC4FLymYfraJ+f1ZiWK3iOUnv9V9_Lg@mail.gmail.com>
 <CANWCAZYbTHwbt6PxPP_s0tWUZ_UMz_CcN2HMy0sWT+8TX7zSCA@mail.gmail.com>
 <CAN4CZFMrj1EB9fDQ4+8o-KzVRhh-FM5U3fXPSnc4YmU-LqNuPA@mail.gmail.com>
 <CANWCAZZez5TX2fQH8Q_K312TC97O-dMQWJPUtLLGQRNBbcYuSQ@mail.gmail.com>
 <CAN4CZFNWZwk3vv3_cD=Z9DonWsSuwX18mRhc10Ktu3vt3gtaYg@mail.gmail.com>
 <CANWCAZbKQ2im1r4ztcyfqNh_6gaJzyewabExYrkACNvMNyqxog@mail.gmail.com>
 <4014992.1771963187@sss.pgh.pa.us> <CANWCAZa8ffe+moS=VeDVUZ9EyPxz_dBqCFpddQrK+dqMkg4=hg@mail.gmail.com>
 <CAN4CZFM8jmh4+1rUR2c++JWK9sV85T8_mqmwHMvM0YWkTm4_dQ@mail.gmail.com>
In-Reply-To: <CAN4CZFM8jmh4+1rUR2c++JWK9sV85T8_mqmwHMvM0YWkTm4_dQ@mail.gmail.com>
From: John Naylor <johncnaylorls@gmail.com>
Date: Fri, 27 Feb 2026 20:38:36 +0700
Message-ID: <CANWCAZbAPFT0w-gZGS4dfJ4HPk7tRAed6vUS67TdEJ1-DoqCHg@mail.gmail.com>
Subject: Re: centralize CPU feature detection
To: Zsolt Parragi <zsolt.parragi@percona.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, 
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, root <tenistarkim@gmail.com>, 
	Nathan Bossart <nathandbossart@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CANWCAZbAPFT0w-gZGS4dfJ4HPk7tRAed6vUS67TdEJ1-DoqCHg%40mail.gmail.com>
Precedence: bulk

On Wed, Feb 25, 2026 at 8:09=E2=80=AFPM Zsolt Parragi <zsolt.parragi@percon=
a.com> wrote:
>
> Both look good to me.

Pushed 0002 after making sure AVX-512 detection still worked, thanks
for the review! I think 0003 needs a link to the Intel manual for the
XCR symbol values, and I'll push shortly after I add that.

> This isn't part of the patch, and it seems harmless, but while
> reviewing the CRC functions, I noticed that pg_crc32c.h  is
> inconsistent with its dllimport markers, pg_comp_crc32c has 3
> different declarations, and only 1 of them is marked PGDLLIMPORT.

Yeah, I think that crept in during development to keep Windows CI
building with a not-for-commit test module. I'll remove it soon.

--=20
John Naylor
Amazon Web Services