Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w4r6Q-002clH-2b for pgsql-hackers@arkaria.postgresql.org; Tue, 24 Mar 2026 02:02:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w4r6P-003cCa-1F for pgsql-hackers@arkaria.postgresql.org; Tue, 24 Mar 2026 02:02:41 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w4r3G-003YGG-0S for pgsql-hackers@lists.postgresql.org; Tue, 24 Mar 2026 01:59:26 +0000 Received: from mail-qt1-x843.google.com ([2607:f8b0:4864:20::843]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1w4r3D-00000000nW6-3hhq for pgsql-hackers@lists.postgresql.org; Tue, 24 Mar 2026 01:59:26 +0000 Received: by mail-qt1-x843.google.com with SMTP id d75a77b69052e-505a1789a27so4083801cf.3 for ; Mon, 23 Mar 2026 18:59:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1774317562; cv=none; d=google.com; s=arc-20240605; b=enQIhcDKPKWioTQVMQOYc0TIH4HPnv8e+CYfTiVruQmkpUw/34OAg/hNOSytEak3Ub EcfrwyDF9ZpR6bX99l7uHVpbAjJ6wxg1LeblOVQbCW+hXQFlVVg+EhxkuusmjAPSVv3p 0y2Hhh+uxJZuGavp7QzHan527J6lxWzhcVXxFZeLuh2QzRQ7dXRbGRHUTwoQlNSKQcKA pYKzczP5l9JjIDwBcF3nrJaHltwqEZQ78Ddr6QSeKkMMa6vlwvp9Z07ljFJ1ChImvcYk B90kMs953xgErxFc5Kh70A/T5Yq7vN62+1BDC2akfCI08sAepnVrKKc8WBg5Jglk3mpK hbcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=r23B/rTEsEZO2qZ9JyIxar5YgYC5oqOW8k0ScsLUr2s=; fh=if8NYeGi+yEEDggY4aX1xcEBGAwCxhNVpFbGlKKpIW0=; b=d+M7DBxouIPgh9p7nr0eSf+8oht56/c+/RVjGLpq3OWIPj3eehy1Cq2KC/iLLRTAsh wWA495w3k/3DzG0EZwxmlwND9oviCkRGeiOYwIOy/wrfTH4qjLy6JA+mhfHDcoBHU/O0 pa5p9+hdpOuFTc9DOJQXLr6dVigcpxbaeVFw235MKMWI5V5FZ5776/cOOvLF0JLoKkHF 0r5A0L6CR1OuPU2RC9v+g6gBFNG6pw0dwbgVr8h3Jjq9IcFuHRGIY27MnTCtSrDddQzd 9NLtfqHU5PY0uArlPe9wjBBcQK/fPZdqc0RrS0fwuV8e2eU3FgE3+i7SXkRKbC5hKOo9 geEA==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774317562; x=1774922362; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=r23B/rTEsEZO2qZ9JyIxar5YgYC5oqOW8k0ScsLUr2s=; b=NaKCBPMbRY4zLVzjgRPVt2Hvg9igXzCNjF4Gkqp+ImyRVz9TgBlOlYwYY4topTGdXl e8AeWNduU9+4zLJOKIunbMnPwS6FhdY08Z2XlOZCoPqN2+iPTQRhGkzvbKhMCGsgLFVp wPYS8O+kioDJ1tbewfeu7hmSJNsQ00he6SkGn3X74TNNV8L4ZZz3Pj9yxO5Ffd8Is/9S +AXPO18muAN492BMNBzEPD6vrW5scXL8WX7lcU3J2M72Qpv9xnqAAkJ+I/CCMfcTlglf 2/3RlK1W8Y/F2YdDQE7ZGLr0eA1hv4Z4NxXBnxmoqvwOiIpguXDx1OU7UwMPyhpOoP+U CawQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774317562; x=1774922362; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=r23B/rTEsEZO2qZ9JyIxar5YgYC5oqOW8k0ScsLUr2s=; b=f7MivDMZ7O+4VEmKO7rdJtRKYz9QqHPrcG51Q2RK5V4UKz6WJ7JjiH4md8DG1tLtQz Bp+NnK3YgNUby6PBHAFdinFi892moTkBV4fvJ9Y2rzVgzLEzohq1xYURmaHxBzK+W+Y7 /Anma/3hvd18ckZdhViG9xXBPFI2d6vLQOlD7BGknV6DOHSWDxQxTBlDzI4VnjjtqC+D tmxi5OTFkvmhN9huFhIPbt9pD5e0rj8YTFrCPGH0shWzT+OxiLdERQD490QzbVYyCs7B 7u/T0cyVcmnfxwetc9rgaqOe2zizWX5nf84FK0GAwpojrw06zgsXj0hjE+z5fWR8ZZoP BWeQ== X-Gm-Message-State: AOJu0YxfFj5HYvxQ+MSzMk3bXkFMb9ft/muokbkgRWgYEZZ0F/h1qLTd +6CqoObBdQ4wOaR2lZ6K5yQIAXwgvUvRLUcztbVJYPGSYDzFa26WWL9g/DewIPVKDsDxcTPkYyY MFjArqUCDYlOth9yIWU/MftrdTtrGhJk= X-Gm-Gg: ATEYQzxD0mPU+WLHk289pRIaC3etzEiWnCZB70DDPtTCrIf7El366KcF2hTnh4eaiXY FAxiyJQ9NidjD/023mvOb2KN7l1QEQhRUpqtwmPRk1X0WjFD28oDlCj2eFgRNy1FF+iPc+VnJdP Vq5Q9wKNW5nE0DuffZX/UCr4EZ0F/YTCjZDlDsHY7DMmKDuciahQLD8ehRq2XlofLpn34woUvgN 5poS5CYeJJxsrjj1Kw+YUgh+RsEqsJdkW13mwRILGaPqY7N405Mtt1Hh5sZGsqO3KMxEsqGiIwa Xx21jnij3xTKCo1f/Ymjc4BiS1V4PpLxjqQCPNvBoSzwDYTLWn7qVY4ys/lLK2/4Ls/60swg7fs +QZHVKn/+Vc5/xyXTHzjp6sww7Qw= X-Received: by 2002:a05:622a:4c12:b0:50b:534f:4285 with SMTP id d75a77b69052e-50b534f440dmr115508841cf.7.1774317561928; Mon, 23 Mar 2026 18:59:21 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: John Naylor Date: Tue, 24 Mar 2026 08:59:11 +0700 X-Gm-Features: AaiRm53XsK2pj64TfiK92tMVUurhMZPv9gioz_TKNWdNGLv1U89DNAG69yw3KM4 Message-ID: Subject: Re: BUG: test_ginpostinglist second itemptr check is a no-op due to copy-paste error To: Jianghua Yang Cc: pgsql-hackers@lists.postgresql.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Mar 24, 2026 at 8:45=E2=80=AFAM Jianghua Yang w= rote: > The attached patch fixes the second check to compare orig_itemptrs[1] > with decoded_itemptrs[1] and reports (blk, off) as the expected > value in the error message. Seems right to me, thanks for the patch. I'll take care of this. --=20 John Naylor Amazon Web Services