MIME-Version: 1.0
References: <EB0141C5-ACC2-4F0B-85EA-0E3AFBCE322F@umbc.edu>
 <CAHEL7KRa-rmSCvREEYrdsY97PNgJtqLYfOikfZWEK4enNQhM0Q@mail.gmail.com>
 <1645542.1778456249@sss.pgh.pa.us>
In-Reply-To: <1645542.1778456249@sss.pgh.pa.us>
From: John Naylor <johncnaylorls@gmail.com>
Date: Mon, 11 May 2026 11:46:06 +0700
Message-ID: 
 <CANWCAZbY43YfBVrsVwSafcxe4YdoaAwP1Keu9shcYA6GA=vnLQ@mail.gmail.com>
Subject: Re: Review - Patch for pg_bsd_indent: improve formatting of multiline
 comments
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: solaimurugan vellaipandiyan <drsolaimurugan.v@gmail.com>,
	Aleksander Alekseev <aleksander@tigerdata.com>,
 Payal Singh <payals1@umbc.edu>,
	pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CANWCAZbY43YfBVrsVwSafcxe4YdoaAwP1Keu9shcYA6GA%3DvnLQ%40mail.gmail.com>
Precedence: bulk

On Mon, May 11, 2026 at 6:37=E2=80=AFAM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Attached are a proposed v8 of the patch, plus two diff files showing
> the effects.  v7-0001.diff.nocfbot is what the v7 patch does with
> today's HEAD (it's the same as before).  The v8 patch makes all those
> changes and in addition makes the ones shown in v8-0001.diff.nocfbot.
> I think those are pretty much all improvements, except that it kind
> of messes up Martin Utesch's ASCII-art signatures in the geqo files.

Agreed, although this one now seems to use even more vertical space
that doesn't contain anything:

-/* Function works as follows:
+/*
+ * Function works as follows:
+ *
  *
  *
- * */
+ */


--=20
John Naylor
Amazon Web Services