MIME-Version: 1.0
References: <75ae5875-3abc-dafc-8aec-73247ed41cde@eisentraut.org>
 <CAFBsxsHMaZ9yR7p=JpzdC2ynKwkDb1PrEr=Q5M__6cmhbbt2iQ@mail.gmail.com>
 <0375b1fb-c2e7-be24-806e-b3b96bd00c31@eisentraut.org>
 <aaa3f9c4-9ad5-d0a1-27ae-6bcd56f5216b@eisentraut.org>
 <9aea7c02-ca6f-4cf0-0e5a-bcc0fd959b7c@eisentraut.org>
 <CAFBsxsEY5tYGpJ3OPEtFd_cW-=DP5WXG3tsCo+f+mAoV+WU8hw@mail.gmail.com>
 <ec503bf6-e2c0-4dff-8261-b3f6e5922c46@eisentraut.org>
 <CANWCAZaDbzRvGTOejr32gxNgWAD_Xs__YW2TfwVQjpRGGr-TGA@mail.gmail.com>
 <4a72ce01-87c2-41a6-baab-f44a4b39e664@eisentraut.org>
In-Reply-To: <4a72ce01-87c2-41a6-baab-f44a4b39e664@eisentraut.org>
From: John Naylor <johncnaylorls@gmail.com>
Date: Fri, 19 Jan 2024 12:28:28 +0700
Message-ID: 
 <CANWCAZbvK_OVAfZPXxK8tey53CTnmwuxgJAbFEBWt57rAUN0Ag@mail.gmail.com>
Subject: Re: generate syscache info automatically
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CANWCAZbvK_OVAfZPXxK8tey53CTnmwuxgJAbFEBWt57rAUN0Ag%40mail.gmail.com>
Precedence: bulk

On Wed, Jan 17, 2024 at 7:46=E2=80=AFPM Peter Eisentraut <peter@eisentraut.=
org> wrote:
>
> I updated the patch to use this style (but I swapped the first two
> arguments from my example, so that the thing being created is named first=
).
>
> I also changed the names of the output files a bit to make them less
> confusing.  (I initially had some files named .c.h, which was weird, but
> apparently necessary to avoid confusing the build system.  But it's all
> clearer now.)
>
> Other than bugs and perhaps style opinions, I think the first patch is
> pretty good now.

LGTM. The only style consideration that occurred to me just now was
MAKE_SYSCACHE, since it doesn't match the DECLARE_... macros. It seems
like the same thing from a code generation perspective. The other
macros refer to relations, so there is a difference, but maybe it
doesn't matter. I don't have a strong opinion.