MIME-Version: 1.0
References: <20220824164624.GA1302727@nathanxps13>
 <20220902220744.GA1261322@nathanxps13>
 <20220923174154.GA1111614@nathanxps13> <20221106223842.GA620653@nathanxps13>
 <20221124001907.GA576983@nathanxps13>
 <CANbhV-EagKLoUH7tLEfg__VcLu37LY78F8gvLMzHrRZyZKm6sw@mail.gmail.com>
 <20221127233434.GA878043@nathanxps13>
 <CANbhV-GXQ+owyk_jnowFRJEVX1TDgQrnQrgQb6C87V6jTecpZA@mail.gmail.com>
 <20221128183129.ip3g5vrcbjrngpp2@awork3.anarazel.de>
 <CA+TgmoY55=uY=_vD-bQX4XjA0BWRC0JfVHTG=jPedXaPc+v4Mg@mail.gmail.com>
 <20221128234039.GA1119654@nathanxps13>
In-Reply-To: <20221128234039.GA1119654@nathanxps13>
From: Simon Riggs <simon.riggs@enterprisedb.com>
Date: Tue, 29 Nov 2022 12:02:44 +0000
Message-ID: 
 <CANbhV-F3hKQCiHKP0gD2bECpcV7hyvF33_iiY_DeYaLgJgjMHA@mail.gmail.com>
Subject: Re: O(n) tasks cause lengthy startups and checkpoints
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>,
	"Bossart, Nathan" <bossartn@amazon.com>,
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
 Maxim Orlov <orlovmg@gmail.com>,
	Amul Sul <sulamul@gmail.com>, Bruce Momjian <bruce@momjian.us>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CANbhV-F3hKQCiHKP0gD2bECpcV7hyvF33_iiY_DeYaLgJgjMHA%40mail.gmail.com>
Precedence: bulk

On Mon, 28 Nov 2022 at 23:40, Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> Okay, here is a new patch set.  0004 adds logic to prevent custodian tasks
> from delaying shutdown.

That all seems good, thanks.

The last important point for me is tests, in src/test/modules
probably. It might be possible to reuse the final state of other
modules' tests to test cleanup, or at least integrate a custodian test
into each module.

-- 
Simon Riggs                http://www.EnterpriseDB.com/