public inbox for [email protected]  

help / color / mirror / Atom feed

From: Simon Riggs <[email protected]>
To: Maxim Orlov <[email protected]>
Cc: Finnerty, Jim <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: Add 64-bit XIDs into PostgreSQL 15
Date: Wed, 12 Jan 2022 13:26:57 +0000
Message-ID: <CANbhV-GFdAJ1J7rdZDcqYVH+u7MSaB2zMmsXm+Vf73MWsEZwJA@mail.gmail.com> (raw)
In-Reply-To: <CACG=ezbCkLkw6-+KpVqTF-8xNieQrbRvaSmrbfnkTgTDoRJHzg@mail.gmail.com>
References: <CACG=ezZe1NQSCnfHOr78AtAZxJZeCvxrts0ygrxYwe=pyyjVWA@mail.gmail.com>
	<[email protected]>
	<CACG=ezbCkLkw6-+KpVqTF-8xNieQrbRvaSmrbfnkTgTDoRJHzg@mail.gmail.com>

On Sat, 8 Jan 2022 at 08:21, Maxim Orlov <[email protected]> wrote:
>>
>>    Perhaps we can merge some of the code cleanup that it contained, such as using XID_FMT everywhere and creating a type for the kind of page returned by TransactionIdToPage() to make the code cleaner.
>
>
> Agree, I think this is a good idea.

Looks to me like the best next actions would be:

1. Submit a patch that uses XID_FMT everywhere, as a cosmetic change.
This looks like it will reduce the main patch size considerably and
make it much less scary. That can be cleaned up and committed while we
discuss the main approach.

2. Write up the approach in a detailed README, so people can
understand the proposal and assess if there are problems. A few short
notes and a link back to old conversations isn't enough to allow wide
review and give confidence on such a major patch.

-- 
Simon Riggs                http://www.EnterpriseDB.com/

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Add 64-bit XIDs into PostgreSQL 15
  In-Reply-To: <CANbhV-GFdAJ1J7rdZDcqYVH+u7MSaB2zMmsXm+Vf73MWsEZwJA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox