MIME-Version: 1.0
References: <b11fa573-38fa-ba57-96a9-e4dd9ce3fb76@2ndquadrant.com>
 <CALAY4q_voAROyjHL0fidvfY7=GGERjqSf0r=uGwrJ-T_9-VBKg@mail.gmail.com>
 <9550e917-c370-36a3-277f-2f25bfc1b497@2ndquadrant.com>
 <CALAY4q88-1P1CWCJKEGHy1S3azG5g8cP_z_sEh+cd0G14YfmgA@mail.gmail.com>
 <1c0f2169-f949-f5c5-9069-b6d0d7e110a7@pgmasters.net>
 <CALAY4q9B=D2EBEVMj6RG5tQPVw-rYw8mvKjDLYF8Bxzjr7APng@mail.gmail.com>
 <CAHHrWDP2txk9FQGqTj39iubHE=eTnoLPqVsBxdDJ-1FS9xZAaQ@mail.gmail.com>
 <CALAY4q9=RTfMu=O9=2Ovzx+iVhU+a4M5ZzxmQ2bvod77dKAg3g@mail.gmail.com>
 <00B5FD97-A568-4270-B0CF-59BA7DEEBFEA@lenstra.fr>
 <CALAY4q8ko8kpY-cm84XNNEnBdSqWUr1K5ZRmWLJy8aXG_Thrjw@mail.gmail.com>
 <20200929054427.GC7117@paquier.xyz>
 <CALAY4q-nAvQ0x3uZV=bQhZjnRHpBTuzzvzFQ263QOCzNcq3S=w@mail.gmail.com>
 <CALAY4q_LCeyMj2KPq2aA5f3L-fPF-kP_w1nuwjZJkrop-o_w=Q@mail.gmail.com>
 <CAN-V+g_ZpK7cbx7szKV8Ma6sNNGy4d34sGh5FMy14h68F8gjBQ@mail.gmail.com>
 <CALAY4q-JMDqW5=LH6f70WhiO1+tP2NhGbWv_fjPtOt=KezchUQ@mail.gmail.com>
 <CAD21AoAUDJj_y_5fH5FLBLUDTZa579jbE5Y12SQz4nJh-RVx7A@mail.gmail.com>
 <CANbhV-EZu-SHXERZ=Bbq5g+ePi7QUX_0WgLtRsove_Jiigtaaw@mail.gmail.com>
 <CANbhV-EOTSc2EWS_LKiXKgLqnrjtaU0hf3Rzxn111nir6Pn4zA@mail.gmail.com>
 <CANbhV-ECkPhsXEtj7gYFjXCdq+3WTiHo9XkF5wQmFOj4w+YTaw@mail.gmail.com>
 <CANbhV-Fb35HMoySGMFfcxN_3i45Bb6cZODOcz8S7+Nys3Y2raA@mail.gmail.com>
 <CAN-V+g-D7bObC3m5rcm3zr8MmTVE4_OVJuEp8Qse0ZgE4PAhsw@mail.gmail.com>
 <CANbhV-F3S=5+5w19cowPwewBXSV3+C5T3BD327KQD7BLFgZbCQ@mail.gmail.com>
 <CAN-V+g_7EC=kAVeQV=+XL+KoV=QLdx_79J55OBarEYd49_uHRA@mail.gmail.com>
In-Reply-To: 
 <CAN-V+g_7EC=kAVeQV=+XL+KoV=QLdx_79J55OBarEYd49_uHRA@mail.gmail.com>
From: Simon Riggs <simon.riggs@enterprisedb.com>
Date: Sat, 9 Jan 2021 10:39:15 +0000
Message-ID: 
 <CANbhV-H-Wt7TVEwzzaYNEZ8-OteipdtvsxN1Qr1G9XpZoX2GgA@mail.gmail.com>
Subject: Re: WIP: System Versioned Temporal Table
To: Ryan Lambert <ryan@rustprooflabs.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>,
 Surafel Temesgen <surafel3000@gmail.com>,
	Michael Paquier <michael@paquier.xyz>,
 =?UTF-8?Q?R=C3=A9mi_Lapeyre?= <remi.lapeyre@lenstra.fr>,
	Eli Marmor <eli@netmask.it>, David Steele <david@pgmasters.net>,
	Vik Fearing <vik.fearing@2ndquadrant.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
 Georgios <gkokolatos@protonmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jan 8, 2021 at 9:19 PM Ryan Lambert <ryan@rustprooflabs.com> wrote:

>> Updated v11 with additional docs and some rewording of messages/tests
>> to use "system versioning" correctly.
>>
>> No changes on the points previously raised.
>>
> Thank you!  The v11 applies and installs.  I tried a simple test, unfortunately it appears the versioning is not working. The initial value is not preserved through an update and a new row does not appear to be created.

Agreed. I already noted this in my earlier review comments.

I will send in a new version with additional tests so we can see more
clearly that the tests fail on the present patch.

I will post more on this next week.

-- 
Simon Riggs                http://www.EnterpriseDB.com/