MIME-Version: 1.0
References: <B80D17B2-2C8E-4C7D-87F2-E5B4BE3C069E@gmail.com>
 <A014A25F-5E45-4C75-9095-8E7BBF26ACDC@gmail.com> <60E6ECA4-C5DB-4F87-9557-1BC094A9F051@gmail.com>
 <CAHv8RjKEBtFfUbmdHPYV1K76bb8PEm6R=iLZko4Dxy2Oh-_uUw@mail.gmail.com>
 <CAHut+PsuJfcaeg6zst=6PE5uyJv_UxVRHU3ck7W2aHb1uQYKng@mail.gmail.com>
 <CAHv8RjJcOsk=y+vJ3y+vXhzR9ZUzUEURvS_90hQW3MNfJ5di7A@mail.gmail.com>
 <CALDaNm3-qiNuf4Wy2E1HtG=SLBJEFGnh010Fqc8eO=Lyg5+pfQ@mail.gmail.com>
 <CAHv8RjJn6EiyAitJbbvkvVV2d45fV3Wjr2VmWFugm3RsbaU+Rg@mail.gmail.com>
 <CANhcyEWm+EUuWViQH9mTuzLAtvTrDCr5vLPoeeVMRK=aUzbRdA@mail.gmail.com>
 <CAHv8Rj+Ai0CgtXiAga82bWpWB8fVcOWycNyJ_jqXm788v3R8rQ@mail.gmail.com>
 <238fd758-ac82-4fa6-aae2-1f9c798c9202@eisentraut.org> <CALDaNm3Ufg872XqgPvBVzXHvUVenu-8+Gz2dyEuKq3CN0UxfKw@mail.gmail.com>
In-Reply-To: <CALDaNm3Ufg872XqgPvBVzXHvUVenu-8+Gz2dyEuKq3CN0UxfKw@mail.gmail.com>
From: Shlok Kyal <shlok.kyal.oss@gmail.com>
Date: Thu, 20 Jun 2024 18:33:15 +0530
Message-ID: <CANhcyEU2vOkdMPnYhykDZdz_PsSdg5ETzGLHF8uawp+UKz8ciA@mail.gmail.com>
Subject: Re: Pgoutput not capturing the generated columns
To: vignesh C <vignesh21@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>, Shubham Khanna <khannashubham1197@gmail.com>, 
	Peter Smith <smithpb2250@gmail.com>, 
	Rajendra Kumar Dangwal <dangwalrajendra888@gmail.com>, pgsql-hackers@lists.postgresql.org, 
	euler@eulerto.com
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CANhcyEU2vOkdMPnYhykDZdz_PsSdg5ETzGLHF8uawp%2BUKz8ciA%40mail.gmail.com>
Precedence: bulk

On Thu, 20 Jun 2024 at 12:52, vignesh C <vignesh21@gmail.com> wrote:
>
> On Wed, 19 Jun 2024 at 21:43, Peter Eisentraut <peter@eisentraut.org> wrote:
> >
> > On 19.06.24 13:22, Shubham Khanna wrote:
> > > All the comments are handled.
> > >
> > > The attached Patch contains all the suggested changes.
> >
> > Please also take a look at the proposed patch for virtual generated
> > columns [0] and consider how that would affect your patch.  I think your
> > feature can only replicate *stored* generated columns.  So perhaps the
> > documentation and terminology in your patch should reflect that.
>
> This patch is unable to manage virtual generated columns because it
> stores NULL values for them. Along with documentation the initial sync
> command being generated also should be changed to sync data
> exclusively for stored generated columns, omitting virtual ones. I
> suggest treating these changes as a separate patch(0003) for future
> merging or a separate commit, depending on the order of patch
> acceptance.
>

I have addressed the issue and updated the documentation accordingly.
And created a new 0003 patch.
Please refer to v9-0003 patch for the same in [1].

[1]: https://www.postgresql.org/message-id/CANhcyEXmjLEPNgOSAtjS4YGb9JvS8w-SO9S%2BjRzzzXo2RavNWw%40mail.gmail.com

Thanks and Regards,
Shlok Kyal