Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wYzlr-000gc8-0z for pgsql-hackers@arkaria.postgresql.org; Mon, 15 Jun 2026 05:22:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wYzlq-009pPB-0e for pgsql-hackers@arkaria.postgresql.org; Mon, 15 Jun 2026 05:22:02 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wYzlp-009pP3-26 for pgsql-hackers@lists.postgresql.org; Mon, 15 Jun 2026 05:22:01 +0000 Received: from mail-oo1-xc2c.google.com ([2607:f8b0:4864:20::c2c]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wYzln-00000000QUm-3giy for pgsql-hackers@lists.postgresql.org; Mon, 15 Jun 2026 05:22:00 +0000 Received: by mail-oo1-xc2c.google.com with SMTP id 006d021491bc7-69d862236ddso1821539eaf.0 for ; Sun, 14 Jun 2026 22:21:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1781500919; cv=none; d=google.com; s=arc-20240605; b=jwtbQCLVJvGn4AO7AGNU9g9pdrX60aKz900UtL3ITSJ86qGQz7nzhz4weFXBomNRG0 5qXyXbjwZfQsnOZiWcQJ2Hxqb7Om4oMbJTEcnz4Rp8IvSthxh7UQNasY6P3M/yqfk4Bk fZodtHbYfJK/e+aO94vdn61Un72d+qrtZuilGvEgwLTXIvKr79vgiNoaSocgUQz0oPyt agu1pu2iGXbCYE+dLaT5+iGv/bO6NImcO5MB78AqXj8G3CgW21JwajiiWMDHcsPF76J4 ulL4w1zaZMdDrFA0jY9EYURxzBwI7n1tvexHqG/RAU/rMc56YTVcjm6YoCI5fXc3C2FC G2mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=WrN47WjsDe2w5Jj0CzDdSTi4wSRSeNdZb722YK44TDM=; fh=XAzECaXtDcoOaKUYkmuXcqBDp+py6TkUSyl51Zq3+r8=; b=fs6g8thBxJDsYLmwD4du5jJuF0EwWEqQD18jnMrP3RzNB34n/92UE6ft7Rn3PYXzhm SYTGxPfPWZhNvz5q46B+p0N3hBlZTJu5R360Ylm7+pZHE2pPP6jVUuUOM2CWQUuRYGFD W0y6JnkQW+kveky0eBDXVtIobbS2F/a2oIou3WVnfp4RFFoG1ITkLDhigBNkaJQzhdrd SxH1jwYNAAgRtuGqp4wa4sHVtL2M48Hb7iUKCBTzbg99rrJNSZsllZa4h+vYtHamG38M OWaOWX3RBARRFWeolqAHVe8Clfx+Glc/d7mkEqYFcI6TA6ST2mWZZAmPpIK/7CKJ2VLj zdyg==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781500919; x=1782105719; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WrN47WjsDe2w5Jj0CzDdSTi4wSRSeNdZb722YK44TDM=; b=TMw33c4Gq+zN8VJR+MnowsdK7dKWDHDtAoAgj9mtqzJ9ZDJgAWBVvlGKQ540Cv1H/H o5VzTvh8R3Ndzolcz7Bq4j19PtLONHC6YD2T4RHi0ldGbcAo03RwNtXS9Px9rvtV1nXs nfLEmXvlWsL3RFdGzOFtReQCTMpVRKZsJnDIEtX1fW+7cSHDSx3TdZ5+KAbEm4IVBVDM 1vCsWKuefNRLkkrmG4jD8Xvt6taq3toEI7ML5Q/ze1rBpKCVHkt9l+HQIGABUYElOrlx JT+H+n2yhw3daH1ltswPnSuYhc5lwLKYHuV3h9wi9nM0BtDRJMN3MhR0PLwNl89eSXWn zxPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781500919; x=1782105719; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WrN47WjsDe2w5Jj0CzDdSTi4wSRSeNdZb722YK44TDM=; b=PO+wF6QU9+4up/aIyRbWRlhIhQOYGtSKCXtY4j4BkZI+/fvvlPTTjJfI1/PkGrknak ISE7pIRDdWcC/hrOOt1JWzIVaYyDsE2+CDrfKjBH0mL6oiCsL03T6JvGRN0Ko/tavAhf uXGvYoRW0n5V405sBAYEc1PrALXd1L4xmtT02gibxL6zzXuAHrwIuQ+1xlCmIrY/DikX t8c0cr0Y8X7fhD5IGccIymf0ZaJzoK4ef6+Vu6mJN5OxKvKThSYtrVKPvDcpYfw26IQl EUwOyBx9WO11AxaIiyKmqLt88ZVUlJb9GuqO130D96yyF7ayB0werrcZOF/bPblRwzZz 0AUg== X-Forwarded-Encrypted: i=1; AFNElJ/rKuBkiM6Kz1Eg0uBBjLYWwSKd3HKAfcMkH9tU9Lqw8ab8OMfvXZ6zKOqmnnniRofJxgraKCx1kJj3I3+3@lists.postgresql.org X-Gm-Message-State: AOJu0YwR+wuYAjl9Ts5g7ldSMsFLApZ0D58U94l3kscFs0urd8hI7Mh+ dXZsOTB9l6LKVDTB4u5GATpLz9rj4kQI/VR3aVI7eBiYbpgsFGQ542aLCEdiX4HaYYab/MN8Ef3 Gi8a/Tji8d16Ues345H0na8p5itzZLZY= X-Gm-Gg: Acq92OEllsm+JWVpnyiTISZYvNmbU2N+cOZJBt6LwcJ1xKd35ABzLtVPXeuGCylBBTV Ztav9Aqonl+AvnhzakWsLjrcYrGmMauT9RXe0CeDpWIiVGmJFcmFZNxah+7DO4Ajo+SAgtKj0Ff sk3ac7FYvv2llUZEnu/OIj8EBOB19Gxp0ot68az22Al1llaTu+jCBvtbjpV8h4LMJpMiX0gnNqX KzXY1RyGldx0SVTz0pAmUlQV7PJQSL02AAUiozso7jnWJ3LS6SOQF44xWGWm7IpSUlDnVd+3t16 k62I4vbx9pYuDXOlU+hmbfOiAXKqalh2497PGDGB1zdNG1mLtsJu X-Received: by 2002:a05:6820:627:b0:69d:e676:6f66 with SMTP id 006d021491bc7-69eec7f2b52mr5407112eaf.21.1781500918724; Sun, 14 Jun 2026 22:21:58 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Shlok Kyal Date: Mon, 15 Jun 2026 10:51:47 +0530 X-Gm-Features: AVVi8CciJkXrCpdhYFIU4oE90jVmIXEmNfBh6cPEL29aKiiv_V0KmfEX-CxkAJc Message-ID: Subject: Re: Proposal: Conflict log history table for Logical Replication To: Dilip Kumar Cc: vignesh C , shveta malik , Amit Kapila , Nisha Moond , Peter Smith , Masahiko Sawada , Bharath Rupireddy , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sat, 13 Jun 2026 at 15:47, Dilip Kumar wrote: > > On Thu, Jun 11, 2026 at 5:53=E2=80=AFPM vignesh C w= rote: > > > > On Thu, 11 Jun 2026 at 10:44, Dilip Kumar wrote= : > > > > > > Please find the rebased patch > > > 1. It includes the new 0005 patch for reporting errors for DDLs on cl= t. > > > > > > Open comments: > > > 1. Recent comments from Nisha and Shveta after v47 are still open > > > 2. Vignesh's patch for "describe related" changes needs a rebase. Can > > > you do that, Vignesh? Meanwhile, I will close all the open comments > > > and try to share a new version by EOD today. > > > > Here is the rebased version of the patch attached. > > Please find attached the latest patch. I have reordered the series, > moving 0006 to 0002, and updated the lock restrictions. We now allow > ACCESS SHARE mode exclusively to ensure pg_dump can acquire its > necessary locks, while blocking higher-level locks to prevent > interference with insertions into the conflict log tables. Hi Dilip and Vignesh, I checked the Cfbot and noticed that one of the 'CompilerWarnings' [1] flow is failing with: describe.c: In function 'describeSubscriptions': describe.c:7456:29: error: 'logdest' may be used uninitialized [-Werror=3Dmaybe-uninitialized] 7456 | if (strcmp(logdest, "table") =3D=3D 0 || strcmp(logdest, "all") =3D= =3D 0) | ^~~~~~~~~~~~~~~~~~~~~~~~ describe.c:7356:29: note: 'logdest' was declared here 7356 | char *logdest; | ^~~~~~~ cc1: all warnings being treated as errors [1]: https://github.com/postgresql-cfbot/postgresql/actions/runs/2746441711= 0/job/81184175578 Thanks, Shlok Kyal