public inbox for [email protected]
help / color / mirror / Atom feedFrom: Shlok Kyal <[email protected]>
To: Peter Smith <[email protected]>
Cc: shveta malik <[email protected]>
Cc: vignesh C <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Support EXCEPT for ALL SEQUENCES publications
Date: Mon, 15 Jun 2026 15:44:00 +0530
Message-ID: <CANhcyEWaYwJqLkPLOjhtL8jeDQtUn71scXsr_NRO4qchbE0SqQ@mail.gmail.com> (raw)
In-Reply-To: <CAHut+Pv4uKN2LEG0-LUwiwzvOX5H074W8zFrKFTntF6__YgssA@mail.gmail.com>
References: <CANhcyEVSXyQkvmrsOWPdQqnm2J3GMyQQrKhyCJiBQzqs6AvSow@mail.gmail.com>
<CALDaNm125dv88fUDgBPBM-N-hXbF0NLqKe-ymEpMRNymUYRQAA@mail.gmail.com>
<CANhcyEUxgzaNJNNO_-12wYwGLihpuKmsMH2g4TFnRPx5AQVZmg@mail.gmail.com>
<CAJpy0uBB4N8KOrHchdgprVi2Ws1+gTcEr+bC2A_ziAHOcZcTqA@mail.gmail.com>
<CAJpy0uCAJQvBjD7qNWWGnZP_LDwS8AiUJC7YMict9UcYqH=XeQ@mail.gmail.com>
<CANhcyEU_Yq9ZJ2n5Sqa7RoHze0TD0RGxLQQgV1F6Jm2AROEh8g@mail.gmail.com>
<CANhcyEWj-ECj=WC+HD_kv27Dn6FkTngFQCVJVTVZfJnjCTKMBQ@mail.gmail.com>
<CANhcyEW03XO5tLb7opt1yQGHWJ7Ew=L65EWcdrKH=F0mUpuR3A@mail.gmail.com>
<CAHut+Ptu0Bkwnr5eetdmFhJC7SsEtKjNe_cTwOg5wF65fjyV8w@mail.gmail.com>
<CANhcyEU+4Z6NXMEk6OmctFv=_pY8K5AiazkfVmn7zxhwQO6CEQ@mail.gmail.com>
<CAHut+PvOWjKJfNorGO8whnaAtqZb-4zN8u6aOajCw3hn-tMwyA@mail.gmail.com>
<CANhcyEV_Sv+xQzsjo6hbowDbGV5J7RhFWuQQxWeUWPNPd0k1=w@mail.gmail.com>
<CAHut+Pt6O3YD8h61RCtzMrRwgvS=RDRNf4KuXAUn1WYnoFU_uQ@mail.gmail.com>
<CANhcyEU=Vi2oNRWTSph3x2884J7aTt5BTb4AzwmmY0uQAsEMMg@mail.gmail.com>
<CAHut+Pv4uKN2LEG0-LUwiwzvOX5H074W8zFrKFTntF6__YgssA@mail.gmail.com>
On Fri, 12 Jun 2026 at 10:59, Peter Smith <[email protected]> wrote:
>
> Some comments for v9-0002.
>
> ======
> APPLY:
>
> 0.
> The patch does not apply cleanly:
>
> $ git apply ../patches_misc/v9-0002-Support-EXCEPT-for-ALL-SEQUENCES-in-ALTER-PUBLICA.patch
> error: patch failed: doc/src/sgml/ref/alter_publication.sgml:277
>
> ======
> doc/src/sgml/ref/alter_publication.sgml
>
> 1.
> + <para>
> + Reset the publication to be a <literal>ALL SEQUENCES</literal> publication
> + with no excluded sequences:
>
> Personally, I don't see how it is good to have "publication" 2x and
> "sequences" 2x in the same sentence.
>
> SUGGESTION
> Reset the publication to be <literal>ALL SEQUENCES</literal> with no exclusions:
>
> ~
>
> I know you're only following the same pattern as "Reset the
> publication to be a FOR ALL TABLES publication with no excluded
> tables:". It is good to be consistent, but when the original text is
> poor, copying it doesn't make it better.
>
> Things like this fall into a grey-zone because, unless they get fixed
> "in-passing", nothing ever changes:
> a) I think a patch to only change the original wording would be
> rejected because it is too trivial.
> b) OTOH, when the original is used as a precedent, the poor wording
> just spreads further.
>
> ~
>
> Anyway, if your chose not to reword this, then there is a typo /a ALL
> SEQUENCES publication/an ALL SEQUENCES publication/
>
Yes, I wanted the text to be consistent with the existing doc. But
after reading your suggestion, I feel your version is more
appropriate. I have updated the patch to use it.
> ======
> src/backend/commands/publicationcmds.c
>
> get_delete_rels:
>
> 2.
> + /* look up the cache for the old relmap */
>
> /look up/Look up/
>
> ~~~
>
> 3.
> + if(found)
> + break;
>
> Missing space after 'if'.
>
> ~~~
>
> 4.
> + oldrel = palloc0_object (PublicationRelInfo);
>
> Unwanted space after function name.
>
I have addressed the remaining comments and have attached the updated
v10 patch in [1].
[1]: https://www.postgresql.org/message-id/CANhcyEVDStqoR3qDSgsv5VEuBMzMX4YpdEfW-7VPX3c5Vf1YJA%40mail.gma...
Thanks,
Shlok Kyal
view thread (41+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Support EXCEPT for ALL SEQUENCES publications
In-Reply-To: <CANhcyEWaYwJqLkPLOjhtL8jeDQtUn71scXsr_NRO4qchbE0SqQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox