public inbox for [email protected]  

help / color / mirror / Atom feed

From: Michail Nikolaev <[email protected]>
To: Simon Riggs <[email protected]>
Cc: Kyotaro Horiguchi <[email protected]>
Cc: Andrey Borodin <[email protected]>
Cc: Alexander Korotkov <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Kirill Reshke <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Slow standby snapshot
Date: Fri, 29 Jul 2022 20:24:30 +0300
Message-ID: <CANtu0ohiyvGNOohEWFo98ySBtifj=yo9JBLd==HkLPrA-ff+PQ@mail.gmail.com> (raw)
In-Reply-To: <CANbhV-FLPO2OzAzKo0DxwqTZtyY9k4XvLGfQ+B=5_dsh+siKEA@mail.gmail.com>
References: <[email protected]>
	<CANtu0ojTfNVaT_WYRrv2+f=OSC4rL_zUGupA41-VHmtkg6kKtQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CANbhV-FLPO2OzAzKo0DxwqTZtyY9k4XvLGfQ+B=5_dsh+siKEA@mail.gmail.com>

Hello.

Thanks to everyone for the review.

> It seems to me storing the index itself is simpler and maybe faster by
> the cycles to perform addition.

Yes, first version used 1-byte for offset with maximum value of 255.
Agreed, looks like there is no sense to store offsets now.

> A simple patch like this seems to hit the main concern, aiming to keep
> the array from spreading out and impacting snapshot performance for
> SELECTs, yet not doing it so often that the startup process has a
> higher burden of work.

Nice, I'll do performance testing for both versions and master branch
as baseline.

Thanks,
Michail.

view thread (68+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Slow standby snapshot
  In-Reply-To: <CANtu0ohiyvGNOohEWFo98ySBtifj=yo9JBLd==HkLPrA-ff+PQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox