MIME-Version: 1.0
References: 
 <CANxoLDejn2JFXF7kVMtcznW6XyessrJ7WToSaQau2GxBdAGSUg@mail.gmail.com>
 <983C7B03-D9C3-4F15-8913-7616EC5E6414@gmail.com>
 <CANxoLDe_GOXyyZs7GN3VUJoT+o1DwqZGhid-TWWvS0D8d5ggYw@mail.gmail.com>
 <20260623.162104.775158751399277188.horikyota.ntt@gmail.com>
 <CANxoLDdq06oXRYuzYfn2gkn3yfoxp=nA14xu5p+qSEOzpHXEMQ@mail.gmail.com>
 <CANxoLDdEBYzKfj3NGrP5PjoTa-eCViWPkFR-sXLq4bUnbokyPA@mail.gmail.com>
 <CAB-JLwbc=9iqgNiLFHAM0-ZMDD=reFsbDS+QFsSepfwZEtRFDQ@mail.gmail.com>
In-Reply-To: 
 <CAB-JLwbc=9iqgNiLFHAM0-ZMDD=reFsbDS+QFsSepfwZEtRFDQ@mail.gmail.com>
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Wed, 24 Jun 2026 13:53:13 +0530
Message-ID: 
 <CANxoLDcRacGAd2Rsmnp=CZjaLMiz7sbCHYo95Rto1OMwJJeOmg@mail.gmail.com>
Subject: Re: [PATCH] Add pg_get_table_ddl() to reconstruct CREATE TABLE
 statements
To: Marcos Pegoraro <marcos@f10.com.br>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, li.evan.chao@gmail.com,
	zsolt.parragi@percona.com, pgsql-hackers@lists.postgresql.org
Content-Type: multipart/alternative; boundary="000000000000ebf0950654fb9633"
Archived-At: 
 <https://www.postgresql.org/message-id/CANxoLDcRacGAd2Rsmnp%3DCZjaLMiz7sbCHYo95Rto1OMwJJeOmg%40mail.gmail.com>
Precedence: bulk

--000000000000ebf0950654fb9633
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 23, 2026 at 7:33=E2=80=AFPM Marcos Pegoraro <marcos@f10.com.br>=
 wrote:

> Em ter., 23 de jun. de 2026 =C3=A0s 10:34, Akshay Joshi <
> akshay.joshi@enterprisedb.com> escreveu:
>
>> A quick note on a design change I made in the *pg_get_table_ddl* option
>> surface
>>
>
> Much better now.
>
> All options can be present or omitted, so why couldn't the owner also be
> part of the include/exclude options too ?
>
> Just one addition, some options are plural and others are not.
> We have indexes, policies, triggers, but we also have check, unique,
> exclusion.
> You don't know how many indices or checks you have, so wouldn't it be
> better to have them in singular form ?
>

Regarding moving owner into the include/exclude syntax, I prefer keeping it
as a top-level boolean for now:
1) It aligns with existing sibling functions (pg_get_role_ddl,
pg_get_tablespace_ddl, and pg_get_database_ddl), which all use a boolean
owner.
2) Existing regression tests and early callers pass owner =3D> false for
output stability. Moving this into the exclude list would create
unnecessary churn that I'd prefer to avoid bundling here.

As for the naming inconsistency (singular vs. plural), you're entirely
right mixing indexes/policies/triggers with checks/uniques/exclusions was
an oversight. Note that I left statistics alone to match the CREATE
STATISTICS keyword.

I'll address the naming consistency in the next patch.

>
> regards
> Marcos
>

--000000000000ebf0950654fb9633
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Jun 23,=
 2026 at 7:33=E2=80=AFPM Marcos Pegoraro &lt;<a href=3D"mailto:marcos@f10.c=
om.br">marcos@f10.com.br</a>&gt; wrote:<br></div><blockquote class=3D"gmail=
_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204=
,204);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr"><div><span style=
=3D"background-color:transparent">Em ter., 23 de jun. de 2026 =C3=A0s 10:34=
, Akshay Joshi &lt;<a href=3D"mailto:akshay.joshi@enterprisedb.com" target=
=3D"_blank">akshay.joshi@enterprisedb.com</a>&gt; escreveu:</span></div></d=
iv><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"ma=
rgin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:=
1ex"><div dir=3D"ltr"><div>A quick note on a design change I made in the <b=
>pg_get_table_ddl</b> option surface</div></div></blockquote><div><br></div=
><div style=3D"font-family:verdana,sans-serif;color:rgb(102,102,102)">Much =
better now. </div><div style=3D"font-family:verdana,sans-serif;color:rgb(10=
2,102,102)"><span style=3D"font-family:Arial,Helvetica,sans-serif;backgroun=
d-color:transparent;color:rgb(34,34,34)"><br></span></div><div style=3D"fon=
t-family:verdana,sans-serif;color:rgb(102,102,102)">All options can be pres=
ent or omitted, so why couldn&#39;t the owner also be part of the include/e=
xclude options too ?</div><div style=3D"font-family:verdana,sans-serif;colo=
r:rgb(102,102,102)"><span style=3D"font-family:Arial,Helvetica,sans-serif;b=
ackground-color:transparent;color:rgb(34,34,34)"><br></span></div><div styl=
e=3D"font-family:verdana,sans-serif;color:rgb(102,102,102)">Just one additi=
on, some options are plural and others are not.</div><div style=3D"font-fam=
ily:verdana,sans-serif;color:rgb(102,102,102)">We have indexes, policies, t=
riggers, but we also have check, unique, exclusion.</div><div style=3D"font=
-family:verdana,sans-serif;color:rgb(102,102,102)">You don&#39;t know how m=
any indices or checks you=C2=A0have, so wouldn&#39;t it be better to have=
=C2=A0them in singular form ?</div></div></div></blockquote><div><br></div>=
Regarding moving owner into the include/exclude syntax, I prefer keeping it=
 as a top-level boolean for now:<br>1) It aligns with existing sibling func=
tions (pg_get_role_ddl, pg_get_tablespace_ddl, and pg_get_database_ddl), wh=
ich all use a boolean owner.<br>2) Existing regression tests and early call=
ers pass owner =3D&gt; false for output stability. Moving this into the exc=
lude list would create unnecessary churn that I&#39;d prefer to avoid bundl=
ing here.<br><br>As for the naming inconsistency (singular vs. plural), you=
&#39;re entirely right mixing indexes/policies/triggers with checks/uniques=
/exclusions was an oversight. Note that I left statistics alone to match th=
e CREATE STATISTICS keyword.<br><br><div><span style=3D"background-color:tr=
ansparent">I&#39;ll address the naming consistency in the next patch.</span=
><span style=3D"background-color:transparent">=C2=A0</span></div><blockquot=
e class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px s=
olid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div class=3D"gmai=
l_quote"><div style=3D"font-family:verdana,sans-serif;color:rgb(102,102,102=
)"><br></div><div style=3D"font-family:verdana,sans-serif;color:rgb(102,102=
,102)">regards</div><div style=3D"font-family:verdana,sans-serif;color:rgb(=
102,102,102)">Marcos</div></div></div>
</blockquote></div></div>

--000000000000ebf0950654fb9633--