MIME-Version: 1.0
References: 
 <CANxoLDfjQnhM=E6JSyYo9s9OdjqoN8s_3wE5yL=kaDu_X8j-dA@mail.gmail.com>
 <CANxoLDcxmXNHNyPt5v+LaBJVJmyt=j95D7TDE9SepoM7y15t-w@mail.gmail.com>
 <CAN4CZFNqf41TCg1ENccq6DAYQpArCbnKUSidHnRKaVMWGj5pBA@mail.gmail.com>
 <CANxoLDfL1AxL=k9SsRNReKQ-sJUSy6RvCqeog5HWckFxff=0Pg@mail.gmail.com>
 <CAN4CZFP5-fAGwxMCyKGePgp3N8NCpoFXkruO=5xjTC=gPwqYxw@mail.gmail.com>
 <CANxoLDc6UFMsyzbXKF8SpMoXdoKE=-yRPqtvyBMKKJ2zOUKX4A@mail.gmail.com>
 <CAN4CZFMhnZyQsdLC5iZNego77JHJyP6J_4CpWu=99vKHCd-vzg@mail.gmail.com>
 <CANxoLDco7z7Fj7_pj_3YQLvjq8ZH2Ai4c3GcOamed01fZhJ77Q@mail.gmail.com>
 <CAB-JLwY=RYPJhdFid0YDqk1L1OQPuHFz9J2tOeeVCFLjov+Ktg@mail.gmail.com>
 <CANxoLDdRts-F+QxL+wtM8529Z3+TUJku8PKy3WoxcWBs7zQJ-w@mail.gmail.com>
 <CAB-JLwbyzF+JRPCoLCf-H6dQ_1+-O_wBZcESRdC6_H2z+-d-gg@mail.gmail.com>
 <CANxoLDcWwoWOxvmV_uBBUsbGf+_AZzBV1GkcjoX+omNpcrCNMQ@mail.gmail.com>
 <CAN4CZFM99cGopPJXD_t05+Y9CnocOOTipfXCzoAfBUFSC-i4+A@mail.gmail.com>
 <CANxoLDejn2JFXF7kVMtcznW6XyessrJ7WToSaQau2GxBdAGSUg@mail.gmail.com>
 <983C7B03-D9C3-4F15-8913-7616EC5E6414@gmail.com>
 <CANxoLDe_GOXyyZs7GN3VUJoT+o1DwqZGhid-TWWvS0D8d5ggYw@mail.gmail.com>
 <D7068A62-6A30-44B9-BADD-0FFACEAD110A@gmail.com>
In-Reply-To: <D7068A62-6A30-44B9-BADD-0FFACEAD110A@gmail.com>
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Mon, 22 Jun 2026 19:41:18 +0530
Message-ID: 
 <CANxoLDdSqqk8hg1m2=-6dv=23ZpRkfEXkZWpGtQT=aTJ0088yg@mail.gmail.com>
Subject: Re: [PATCH] Add pg_get_table_ddl() to reconstruct CREATE TABLE
 statements
To: Chao Li <li.evan.chao@gmail.com>
Cc: Zsolt Parragi <zsolt.parragi@percona.com>,
 pgsql-hackers@lists.postgresql.org
Content-Type: multipart/alternative; boundary="000000000000120dbe0654d83863"
Archived-At: 
 <https://www.postgresql.org/message-id/CANxoLDdSqqk8hg1m2%3D-6dv%3D23ZpRkfEXkZWpGtQT%3DaTJ0088yg%40mail.gmail.com>
Precedence: bulk

--000000000000120dbe0654d83863
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 22, 2026 at 7:30=E2=80=AFPM Chao Li <li.evan.chao@gmail.com> wr=
ote:

>
>
> > On Jun 22, 2026, at 20:40, Akshay Joshi <akshay.joshi@enterprisedb.com>
> wrote:
> >
> > You're right, and thanks for spotting this. The existing pattern in
> pg_proc.dat for variadic-text functions (e.g., jsonb_delete,
> json_extract_path) uses _text at the variadic position in both proargtype=
s
> and proallargtypes, with provariadic =3D> 'text'. That is the convention
> documented by the sanity check in src/test/regress/sql/opr_sanity.sql.
> >
> > The same issue applies to pg_get_role_ddl, pg_get_tablespace_ddl (both
> variants), and pg_get_database_ddl, but that will require a separate patc=
h.
> >
>
> Thanks for confirming. Then I will file a patch tomorrow to fix those.
>

   I started working on it, but if you want to take the lead, just let me
know and I won't send my version over

>
> Best regards,
> --
> Chao Li (Evan)
> HighGo Software Co., Ltd.
> https://www.highgo.com/
>
>
>
>
>

--000000000000120dbe0654d83863
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Jun 22,=
 2026 at 7:30=E2=80=AFPM Chao Li &lt;<a href=3D"mailto:li.evan.chao@gmail.c=
om">li.evan.chao@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D"gma=
il_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,2=
04,204);padding-left:1ex"><br>
<br>
&gt; On Jun 22, 2026, at 20:40, Akshay Joshi &lt;<a href=3D"mailto:akshay.j=
oshi@enterprisedb.com" target=3D"_blank">akshay.joshi@enterprisedb.com</a>&=
gt; wrote:<br>
&gt; <br>
&gt; You&#39;re right, and thanks for spotting this. The existing pattern i=
n pg_proc.dat for variadic-text functions (e.g., jsonb_delete, json_extract=
_path) uses _text at the variadic position in both proargtypes and proallar=
gtypes, with provariadic =3D&gt; &#39;text&#39;. That is the convention doc=
umented by the sanity check in src/test/regress/sql/opr_sanity.sql.<br>
&gt; <br>
&gt; The same issue applies to pg_get_role_ddl, pg_get_tablespace_ddl (both=
 variants), and pg_get_database_ddl, but that will require a separate patch=
.<br>
&gt; <br>
<br>
Thanks for confirming. Then I will file a patch tomorrow to fix those.<br><=
/blockquote><div><br>=C2=A0 =C2=A0I started working on it, but if you want =
to take the lead, just let me know and I won&#39;t send my version over=C2=
=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8e=
x;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Best regards,<br>
--<br>
Chao Li (Evan)<br>
HighGo Software Co., Ltd.<br>
<a href=3D"https://www.highgo.com/" rel=3D"noreferrer" target=3D"_blank">ht=
tps://www.highgo.com/</a><br>
<br>
<br>
<br>
<br>
</blockquote></div></div>

--000000000000120dbe0654d83863--