MIME-Version: 1.0
References: <CANxoLDfca8O5SkeDxB_j6SVNXd+pNKaDmVmEW+2yyicdU8fy0w@mail.gmail.com>
 <3bd49b59-7a87-4ab6-9eac-59b5d9cb78de@dunslane.net> <1133418.1771260634@sss.pgh.pa.us>
 <CAExHW5uSuG9qcGd=o6o6TiwWUKE4ie7K7nmgKzDzUKxrQ9rYDw@mail.gmail.com>
In-Reply-To: <CAExHW5uSuG9qcGd=o6o6TiwWUKE4ie7K7nmgKzDzUKxrQ9rYDw@mail.gmail.com>
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Tue, 17 Feb 2026 13:24:05 +0530
Message-ID: <CANxoLDdbhQbap5vd3=01ad67EGbGNKDsvZdYVT3KRUiy-onYqA@mail.gmail.com>
Subject: Re: [PATCH] pgindent truncates last line of files missing a trailing newline
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan <andrew@dunslane.net>, 
	pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000e4e6d5064b0060b6"
Archived-At: <https://www.postgresql.org/message-id/CANxoLDdbhQbap5vd3%3D01ad67EGbGNKDsvZdYVT3KRUiy-onYqA%40mail.gmail.com>
Precedence: bulk

--000000000000e4e6d5064b0060b6
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

I have addressed the review comments from Andrew.
Attached is the v2 patch, ready for review.

On Tue, Feb 17, 2026 at 7:50=E2=80=AFAM Ashutosh Bapat
<ashutosh.bapat.oss@gmail.com> wrote:
>
> On Mon, Feb 16, 2026 at 10:20=E2=80=AFPM Tom Lane <tgl@sss.pgh.pa.us> wro=
te:
> >
> > Andrew Dunstan <andrew@dunslane.net> writes:
> > > Yeah. I wonder if we shouldn't be just ensuring that there is a line
> > > feed at the end of the buffer, i.e. add one if it's not there. We
> > > shouldn't be adding files without a trailing LF, and ensuring there i=
s
> > > one seems like a reasonable thing to do in pg_bsd_indent.
> >
> > +1
>
> +1. That will allow me to remove some code from my patch preparation
> script. Ref. [1]
>
> [1] https://www.postgresql.org/message-id/flat/CAExHW5v8u7-2H2LqWP3ybhh5G=
nAVVeCOYuTfkg9pmdnrLwAtNA%40mail.gmail.com#fdbb87e825f89e7109dfb0ed959b2dd4
>
> --
> Best Wishes,
> Ashutosh Bapat

--000000000000e4e6d5064b0060b6
Content-Type: application/octet-stream; 
	name="v2-0001-Fix-pgindent-truncates-last-line-of-files.patch"
Content-Disposition: attachment; 
	filename="v2-0001-Fix-pgindent-truncates-last-line-of-files.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mlqb4bvo0>
X-Attachment-Id: f_mlqb4bvo0

RnJvbSBmMWY0YzI4ODZlMDdkOGEzNzZjMzRjZDk1OGVlYTE1MzRlZTVmOTZlIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBa3NoYXkgSm9zaGkgPGFrc2hheS5qb3NoaUBlbnRlcnByaXNl
ZGIuY29tPgpEYXRlOiBNb24sIDE2IEZlYiAyMDI2IDE2OjM5OjA4ICswNTMwClN1YmplY3Q6IFtQ
QVRDSF0gRml4IHBnaW5kZW50IHRvIGVuc3VyZSBmaWxlcyBlbmQgd2l0aCBhIHRyYWlsaW5nIG5l
d2xpbmUuCgpJZiBhIHNvdXJjZSBmaWxlIGlzIG1pc3NpbmcgYSB0cmFpbGluZyBuZXdsaW5lLCBw
Z19ic2RfaW5kZW50IG5vdyBhZGRzCm9uZS4gVGhlIGZpbGxfYnVmZmVyKCkgZnVuY3Rpb24gYWxy
ZWFkeSBhZGRzIGEgc3ludGhldGljIG5ld2xpbmUgYXQgRU9GOwp0aGlzIGNoYW5nZSBlbnN1cmVz
IHRoYXQgbmV3bGluZSBpcyBlbWl0dGVkIHRvIHRoZSBvdXRwdXQgcmF0aGVyIHRoYW4KYmVpbmcg
c3VwcHJlc3NlZC4KCkF1dGhvcjogQWtzaGF5IEpvc2hpIDxha3NoYXkuam9zaGlAZW50ZXJwcmlz
ZWRiLmNvbT4KUmV2aWV3ZWQtYnk6IEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0
PgotLS0KIHNyYy90b29scy9wZ19ic2RfaW5kZW50L2xleGkuYyAgICAgICAgICAgICAgICB8IDI5
ICsrKysrKysrKysrKysrKy0tLS0KIC4uLi9wZ19ic2RfaW5kZW50L3Rlc3RzL25vX3RyYWlsaW5n
X25ld2xpbmUuMCB8ICA0ICsrKwogLi4uL3Rlc3RzL25vX3RyYWlsaW5nX25ld2xpbmUuMC5zdGRv
dXQgICAgICAgIHwgIDYgKysrKwogMyBmaWxlcyBjaGFuZ2VkLCAzMyBpbnNlcnRpb25zKCspLCA2
IGRlbGV0aW9ucygtKQogY3JlYXRlIG1vZGUgMTAwNjQ0IHNyYy90b29scy9wZ19ic2RfaW5kZW50
L3Rlc3RzL25vX3RyYWlsaW5nX25ld2xpbmUuMAogY3JlYXRlIG1vZGUgMTAwNjQ0IHNyYy90b29s
cy9wZ19ic2RfaW5kZW50L3Rlc3RzL25vX3RyYWlsaW5nX25ld2xpbmUuMC5zdGRvdXQKCmRpZmYg
LS1naXQgYS9zcmMvdG9vbHMvcGdfYnNkX2luZGVudC9sZXhpLmMgYi9zcmMvdG9vbHMvcGdfYnNk
X2luZGVudC9sZXhpLmMKaW5kZXggOTQzYmY3Y2U2YjAuLmIwMjZmZWY2ZmNhIDEwMDY0NAotLS0g
YS9zcmMvdG9vbHMvcGdfYnNkX2luZGVudC9sZXhpLmMKKysrIGIvc3JjL3Rvb2xzL3BnX2JzZF9p
bmRlbnQvbGV4aS5jCkBAIC00NTMsMTIgKzQ1MywyOSBAQCBsZXhpKHN0cnVjdCBwYXJzZXJfc3Rh
dGUgKnN0YXRlKQogICAgIGNhc2UgJ1xuJzoKIAl1bmFyeV9kZWxpbSA9IHN0YXRlLT5sYXN0X3Vf
ZDsKIAlzdGF0ZS0+bGFzdF9ubCA9IHRydWU7CS8qIHJlbWVtYmVyIHRoYXQgd2UganVzdCBoYWQg
YSBuZXdsaW5lICovCi0JY29kZSA9IChoYWRfZW9mID8gMCA6IG5ld2xpbmUpOwotCi0JLyoKLQkg
KiBpZiBkYXRhIGhhcyBiZWVuIGV4aGF1c3RlZCwgdGhlIG5ld2xpbmUgaXMgYSBkdW1teSwgYW5k
IHdlIHNob3VsZAotCSAqIHJldHVybiBjb2RlIHRvIHN0b3AKLQkgKi8KKwl7CisJCS8qCisJCSog
RW5zdXJlIHdlIG91dHB1dCBleGFjdGx5IG9uZSBuZXdsaW5lIGF0IEVPRjogZWl0aGVyIHRoZSBm
aWxlJ3MgcmVhbAorCQkqIHRyYWlsaW5nIG5ld2xpbmUsIG9yIHRoZSBzeW50aGV0aWMgb25lIGFk
ZGVkIGJ5IGZpbGxfYnVmZmVyKCkgaWYgdGhlCisJCSogZmlsZSB3YXMgbWlzc2luZyBvbmUuCisJ
CSovCisJCXN0YXRpYyBib29sIGZpbmFsX25ld2xpbmVfZG9uZSA9IGZhbHNlOworCisJCWlmICho
YWRfZW9mKQorCQl7CisJCQlpZiAoZmluYWxfbmV3bGluZV9kb25lKQorCQkJCWNvZGUgPSAwOwkJ
CS8qIGFscmVhZHkgZW1pdHRlZCBmaW5hbCBuZXdsaW5lLCBzdG9wIG5vdyAqLworCQkJZWxzZQor
CQkJeworCQkJCWNvZGUgPSBuZXdsaW5lOworCQkJCWZpbmFsX25ld2xpbmVfZG9uZSA9IHRydWU7
CisJCQl9CisJCX0KKwkJZWxzZQorCQl7CisJCQljb2RlID0gbmV3bGluZTsKKwkJfQorCX0KIAli
cmVhazsKIAogICAgIGNhc2UgJ1wnJzoJCQkvKiBzdGFydCBvZiBxdW90ZWQgY2hhcmFjdGVyICov
CmRpZmYgLS1naXQgYS9zcmMvdG9vbHMvcGdfYnNkX2luZGVudC90ZXN0cy9ub190cmFpbGluZ19u
ZXdsaW5lLjAgYi9zcmMvdG9vbHMvcGdfYnNkX2luZGVudC90ZXN0cy9ub190cmFpbGluZ19uZXds
aW5lLjAKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLjMyMzM5OTBlMTFm
Ci0tLSAvZGV2L251bGwKKysrIGIvc3JjL3Rvb2xzL3BnX2JzZF9pbmRlbnQvdGVzdHMvbm9fdHJh
aWxpbmdfbmV3bGluZS4wCkBAIC0wLDAgKzEsNCBAQAorLyogVGVzdDogZmlsZSB3aXRob3V0IHRy
YWlsaW5nIG5ld2xpbmUgKi8KK3ZvaWQgdGVzdCh2b2lkKSB7CitpbnQgeCA9IDE7Cit9ClwgTm8g
bmV3bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZmIC0tZ2l0IGEvc3JjL3Rvb2xzL3BnX2JzZF9pbmRl
bnQvdGVzdHMvbm9fdHJhaWxpbmdfbmV3bGluZS4wLnN0ZG91dCBiL3NyYy90b29scy9wZ19ic2Rf
aW5kZW50L3Rlc3RzL25vX3RyYWlsaW5nX25ld2xpbmUuMC5zdGRvdXQKbmV3IGZpbGUgbW9kZSAx
MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLmM2MzJkNjJmMTZjCi0tLSAvZGV2L251bGwKKysrIGIv
c3JjL3Rvb2xzL3BnX2JzZF9pbmRlbnQvdGVzdHMvbm9fdHJhaWxpbmdfbmV3bGluZS4wLnN0ZG91
dApAQCAtMCwwICsxLDYgQEAKKy8qIFRlc3Q6IGZpbGUgd2l0aG91dCB0cmFpbGluZyBuZXdsaW5l
ICovCit2b2lkCit0ZXN0KHZvaWQpCit7CisJaW50CQl4ID0gMTsKK30KLS0gCjIuNTEuMAoK
--000000000000e4e6d5064b0060b6--