MIME-Version: 1.0
References: 
 <CAPgqM1V4LW2qiDLPsusb7s0kYbSDJjH5Tt+-ZzVmPU7xV0TJNQ@mail.gmail.com>
 <CACJufxE_8DveuvpiSnnRpeRGC9UdGY6X7ZptNt08-x+v-_5QQg@mail.gmail.com>
 <CAPgqM1URzR017U5gEK6S5dYz8VdYMaJf82G9sZFq5xbpHR1J_g@mail.gmail.com>
 <E3B668DD-7D16-418F-819A-052B893C1B02@gmail.com>
 <CAPgqM1XBMQGP=w2a9jajGkrGMzVk0rGBm0+F1pnwsZnn_U6YoQ@mail.gmail.com>
In-Reply-To: 
 <CAPgqM1XBMQGP=w2a9jajGkrGMzVk0rGBm0+F1pnwsZnn_U6YoQ@mail.gmail.com>
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Thu, 23 Oct 2025 14:49:48 +0530
Message-ID: 
 <CANxoLDeXxHgZXcO1HAimT0KkZm19wjLvNXct+sq7Lg+aBFKG3w@mail.gmail.com>
Subject: Re: [PATCH] pg_get_domain_ddl: DDL reconstruction function for CREATE
 DOMAIN statement
To: Tim Waizenegger <tim.waizenegger@enterprisedb.com>
Cc: Chao Li <li.evan.chao@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000efb78d0641cfefef"
Archived-At: 
 <https://www.postgresql.org/message-id/CANxoLDeXxHgZXcO1HAimT0KkZm19wjLvNXct%2Bsq7Lg%2BaBFKG3w%40mail.gmail.com>
Precedence: bulk

--000000000000efb78d0641cfefef
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 22 Oct, 2025, 17:30 Tim Waizenegger, <
tim.waizenegger@enterprisedb.com> wrote:

> On Wed, Oct 22, 2025 at 12:27=E2=80=AFPM Chao Li <li.evan.chao@gmail.com>=
 wrote:
> >
> > Hi Tim,
> >
> > Thanks for working on this. I haven=E2=80=99t finished reviewing the en=
tire
> patch. But I got a quick question:
> >
> > While reviewing a similar patch of pg_get_policy_ddl(), it take the las=
t
> parameter as a pretty flag. I wonder why pg_get_domain_ddl() doesn=E2=80=
=99t
> support an argument for pretty?
> >
> >
>
> That's a good point; we'll add pretty printing support for consistency
> with the other functions. I'll send a new patch in the coming days.
>

I've already implemented a generic function for pretty-formatted DDL in the
ruleutils.c file as part of my pg_get_policy_ddl patch. I suggest reusing
it once my patch is accepted and committed by the community.

>
> Best regards,
> Florin Irion
> Tim Waizenegger
> EDB (EnterpriseDB)
>
>
>

--000000000000efb78d0641cfefef
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div><br><br><div class=3D"gmail_quote gmail_quote_contai=
ner"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, 22 Oct, 2025, 17:30 Tim =
Waizenegger, &lt;<a href=3D"mailto:tim.waizenegger@enterprisedb.com">tim.wa=
izenegger@enterprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gma=
il_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-lef=
t:1ex">On Wed, Oct 22, 2025 at 12:27=E2=80=AFPM Chao Li &lt;<a href=3D"mail=
to:li.evan.chao@gmail.com" target=3D"_blank" rel=3D"noreferrer">li.evan.cha=
o@gmail.com</a>&gt; wrote:<br>
&gt;<br>
&gt; Hi Tim,<br>
&gt;<br>
&gt; Thanks for working on this. I haven=E2=80=99t finished reviewing the e=
ntire patch. But I got a quick question:<br>
&gt;<br>
&gt; While reviewing a similar patch of pg_get_policy_ddl(), it take the la=
st parameter as a pretty flag. I wonder why pg_get_domain_ddl() doesn=E2=80=
=99t support an argument for pretty?<br>
&gt;<br>
&gt;<br>
<br>
That&#39;s a good point; we&#39;ll add pretty printing support for consiste=
ncy<br>
with the other functions. I&#39;ll send a new patch in the coming days.<br>=
</blockquote></div></div><div dir=3D"auto"><br></div><div dir=3D"auto">I=
9;ve already implemented a generic function for pretty-formatted DDL in the=
=C2=A0<code>ruleutils.c</code> file as part of my=C2=A0<code>pg_get_policy_=
ddl</code> patch.=C2=A0I suggest reusing it once my patch is accepted and c=
ommitted by the community.</div><div dir=3D"auto"><div class=3D"gmail_quote=
 gmail_quote_container"><blockquote class=3D"gmail_quote" style=3D"margin:0=
 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Best regards,<br>
Florin Irion<br>
Tim Waizenegger<br>
EDB (EnterpriseDB)<br>
<br>
<br>
</blockquote></div></div></div>

--000000000000efb78d0641cfefef--