MIME-Version: 1.0
References: 
 <CANxoLDdPqyTLyYhBnekFYkaSn_8DBdtf32cH=MLNJc=+BQP=MQ@mail.gmail.com>
 <202511191045.tckydhpoxumx@alvherre.pgsql>
In-Reply-To: <202511191045.tckydhpoxumx@alvherre.pgsql>
From: Akshay Joshi <akshay.joshi@enterprisedb.com>
Date: Wed, 19 Nov 2025 16:37:27 +0530
Message-ID: 
 <CANxoLDfb8w7xOS+GHAkETiBtVLv8HM+fmf1vyvS51+whAXQMWQ@mail.gmail.com>
Subject: Re: [PATCH] Add pg_get_database_ddl() function to reconstruct CREATE
 DATABASE statement
To: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>
Cc: Chao Li <li.evan.chao@gmail.com>, Japin Li <japinli@hotmail.com>,
	Quan Zongliang <quanzongliang@yeah.net>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000a41a4c0643f096bd"
Archived-At: 
 <https://www.postgresql.org/message-id/CANxoLDfb8w7xOS%2BGHAkETiBtVLv8HM%2Bfmf1vyvS51%2BwhAXQMWQ%40mail.gmail.com>
Precedence: bulk

--000000000000a41a4c0643f096bd
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Thanks =C3=81lvaro
Will work on it and send the updated patch.

On Wed, Nov 19, 2025 at 4:17=E2=80=AFPM =C3=81lvaro Herrera <alvherre@kuril=
emu.de> wrote:

> Hello,
>
> One thing I realized a few days ago is that since commit bd09f024a1bb we
> have type regdatabase, so instead of having two functions (one taking
> name and one taking Oid), we should have just one, taking regdatabase,
> just like the functions for producing DDL for other object types that
> have corresponding reg* type.
>
> Regards,
>
> --
> =C3=81lvaro Herrera         PostgreSQL Developer  =E2=80=94
> https://www.EnterpriseDB.com/
>

--000000000000a41a4c0643f096bd
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Thanks=C2=A0=C3=81lvaro<br>Will work on it and send the up=
dated patch.</div><br><div class=3D"gmail_quote gmail_quote_container"><div=
 dir=3D"ltr" class=3D"gmail_attr">On Wed, Nov 19, 2025 at 4:17=E2=80=AFPM =
=C3=81lvaro Herrera &lt;<a href=3D"mailto:alvherre@kurilemu.de">alvherre@ku=
rilemu.de</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex">Hello,<br>
<br>
One thing I realized a few days ago is that since commit bd09f024a1bb we<br=
>
have type regdatabase, so instead of having two functions (one taking<br>
name and one taking Oid), we should have just one, taking regdatabase,<br>
just like the functions for producing DDL for other object types that<br>
have corresponding reg* type.<br>
<br>
Regards,<br>
<br>
-- <br>
=C3=81lvaro Herrera=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0PostgreSQL Developer=
=C2=A0 =E2=80=94=C2=A0 <a href=3D"https://www.EnterpriseDB.com/" rel=3D"nor=
eferrer" target=3D"_blank">https://www.EnterpriseDB.com/</a><br>
</blockquote></div>

--000000000000a41a4c0643f096bd--