MIME-Version: 1.0
References: 
 <CAO6_Xqo3co3BuUVEVzkaBVw9LidBgeeQ_2hfxeLMQcXwovB3GQ@mail.gmail.com>
 <CAO6_XqrZEREa5d+dyjahX6bteBhoN=8Jid-3a4f6Q35sWrv9eg@mail.gmail.com>
 <CAHGQGwHFKF+x4E+SqedMCnmLCitxjTUUtSyL_+mMeuq-GbEt6w@mail.gmail.com>
 <CAO6_Xqp+ADb6KZVWLMALu3xmwVUEO8S1EiCnp38mG6BrHrEnuA@mail.gmail.com>
 <CAO6_XqqKDV+AuP=Gf4kRKPqzyYTsOyGd3LE8Jqkwi7EMPJpbhA@mail.gmail.com>
 <CAHGQGwHc5yH4Nxp59KXJP0kAr61j3W7QeSKT2HxVjZa3OrLzmg@mail.gmail.com>
In-Reply-To: 
 <CAHGQGwHc5yH4Nxp59KXJP0kAr61j3W7QeSKT2HxVjZa3OrLzmg@mail.gmail.com>
From: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>
Date: Wed, 4 Mar 2026 09:51:56 +0100
Message-ID: 
 <CAO6_Xqq1h6kggb1o206rgouPS0H5jnjahzZ0We-9ggnBjB2JsA@mail.gmail.com>
Subject: Re: Shutdown indefinitely stuck due to unflushed FPI_FOR_HINT record
To: Fujii Masao <masao.fujii@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000053035f064c2eef41"
Archived-At: 
 <https://www.postgresql.org/message-id/CAO6_Xqq1h6kggb1o206rgouPS0H5jnjahzZ0We-9ggnBjB2JsA%40mail.gmail.com>
Precedence: bulk

--00000000000053035f064c2eef41
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 3, 2026 at 6:29=E2=80=AFPM Fujii Masao <masao.fujii@gmail.com> =
wrote:
> The approach of calling XLogSetAsyncXactLSN() in RecordTransactionAbort()=
 seems
> more like an improvement than a bug fix. Since it changes
> RecordTransactionAbort(), it could have unintended impact on the system.
>
> It may be a reasonable idea (though I'm not certain yet), but for a bug f=
ix
> I believe we should first apply the minimal change necessary to resolve
> the issue. If needed, this approach could then be proposed later separate=
ly as
> an improvement for the next major version.

Agreed, that's definitely a change that can have a large impact. I
will open a separate thread later.

> As a simpler alternative, would it make sense for walsender to call
> XLogFlush(GetXLogInsertRecPtr()) instead of XLogBackgroundFlush() during
> shutdown? I'm not sure why walsender currently uses XLogBackgroundFlush()=
.
> If there isn't a clear reason for that choice, directly calling XLogFlush=
()
> might be the simpler solution. Thought?

That sounds like a good solution. I've tried it and it fixes the
issue. And this only changes the shutdown behaviour in the walsender.

The use of XLogBackgroundFlush() has been introduced with
c6c333436491, but there's no mention why it was specifically used. I
guess the assumption was that a change would either be flushed with a
commit, or tracked by async LSN through rollback, so
XLogBackgroundFlush() would always write pending records. But this
turns out to be false in the case of this bug.

I've updated the patch with this approach.

Regards,
Anthonin Bonnefoy

--00000000000053035f064c2eef41
Content-Type: application/octet-stream;
	name="v5-0001-Fix-stuck-shutdown-due-to-unflushed-records.patch"
Content-Disposition: attachment;
	filename="v5-0001-Fix-stuck-shutdown-due-to-unflushed-records.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mmbsij2k0>
X-Attachment-Id: f_mmbsij2k0

RnJvbSAwZTA2YzVmZTQ1MTgzMjI3NmYyNmNiM2E4NjExMTIyOGU3ODUyNWE0IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRob25pbiBCb25uZWZveSA8YW50aG9uaW4uYm9ubmVmb3lA
ZGF0YWRvZ2hxLmNvbT4KRGF0ZTogVHVlLCAzIE1hciAyMDI2IDE3OjQyOjQwICswMTAwClN1Ympl
Y3Q6IEZpeCBzdHVjayBzaHV0ZG93biBkdWUgdG8gdW5mbHVzaGVkIHJlY29yZHMKClNodXRkb3du
IHNlcXVlbmNlIG1heSBiZSBzdHVjayBpbmRlZmluaXRlbHkgdW5kZXIgdGhlIGZvbGxvd2luZwpj
aXJjdW1zdGFuY2VzOgotIERhdGEgY2hlY2tzdW1zIGlzIGVuYWJsZWQKLSBBIGxvZ2ljYWwgcmVw
bGljYXRpb24gd2Fsc2VuZGVyIGlzIHJ1bm5pbmcKLSBBIHNlbGVjdCBpbiBhbiBleHBsaWNpdCB0
cmFuc2FjdGlvbiB0cmllcyB0byBwcnVuZSBhIGZ1bGwgaGVhcCBwYWdlLAogIHdyb3RlIGEgRlBJ
X0ZPUl9ISU5UIHJlY29yZCB3aGljaCBjcm9zc2VzIHRoZSBwYWdlIGJvdW5kYXJ5Ci0gVGhlIHNl
bGVjdCBpcyByb2xsYmFja2VkIChvciBraWxsZWQpCi0gJ3BnX2N0bCBzdG9wJyBpcyBzZW50CgpU
aGUgRlBJX0ZPUl9ISU5UIHJlY29yZCBpcyBsaWtlbHkgZ29pbmcgdG8gYmUgYSBjb250cmVjb3Jk
IGFuZCBzdGFydHMgYQpuZXcgcGFnZS4gSG93ZXZlciwgYXMgdGhlIHNlbGVjdCBpcyByb2xsYmFj
a2VkLCBYTG9nU2V0QXN5bmNYYWN0TFNOCmlzbid0IGNhbGxlZCB0byBhZHZhbmNlIHRoZSBMU04g
dG8gaW5jbHVkZSB0aGlzIHJlY29yZC4KCldoZW4gdGhlIGNoZWNrcG9pbnRlciBzdGFydHMgU2h1
dGRvd25YTE9HKCksIGFsbCB3YWxzZW5kZXJzIHdpbGwgYmUKbm90aWZpZWQgdG8gc3RvcC4gSG93
ZXZlciwgdGhlIGxvZ2ljYWwgcmVwbGljYXRpb24gd2Fsc2VuZGVyIHdpbGwgYmUKc3R1Y2sgaW4g
dGhlIGZvbGxvd2luZyBpbmZpbml0ZSBsb29wOgotIFRyaWVzIHRvIHJlYWQgdGhlIGxhc3QgRlBJ
X0ZPUl9ISU5UIHJlY29yZAotIFRoZSBwYWdlIHdpdGggdGhlIHJlY29yZCBoZWFkZXIgaXMgcmVh
ZAotIHRvdF9sZW4gPiBsZW4sIHRoZSByZWNvcmQgbmVlZHMgdG8gYmUgcmVhc3NlbWJsZWQKLSBU
cmllcyB0byByZWFkIHRoZSBuZXh0IHBhZ2UgY29udGFpbmluZyB0aGUgcmVzdCBvZiB0aGUgcmVj
b3JkLiBJdCBmYWlscyBzaW5jZSB0aGlzIHBhZ2Ugd2FzIG5ldmVyIHdyaXR0ZW4uCi0geGxvZyBy
ZWFkZXIgc3RhdGUgaXMgcmVzZXQgd2l0aCBYTG9nUmVhZGVySW52YWxSZWFkU3RhdGUKLSBJdCBn
b2VzIGJhY2sgdG8gdGhlIHN0YXJ0IG9mIFdhbFNuZExvb3AncyBsb29wCgpUaGVyZSBhcmUgc29t
ZSBhdHRlbXB0cyBkb25lIGJ5IHRoZSB3YWxzZW5kZXIgdG8gZmx1c2ggdGhlIFdBTCB1c2luZwpY
TG9nQmFja2dyb3VuZEZsdXNoLiBIb3dldmVyLCBYTG9nQmFja2dyb3VuZEZsdXNoIG9ubHkgd3Jp
dGVzIGNvbXBsZXRlZApibG9ja3MsIG9yIHVwIHRvIHRoZSBsYXRlc3Qga25vd24gYXN5bmMgbHNu
LiBTaW5jZSB0aGUgc2VsZWN0IHdhcwpyb2xsYmFja2VkLCBYTG9nQmFja2dyb3VuZEZsdXNoIGRv
ZXNuJ3QgZmx1c2ggdGhlIG5leHQgcGFydGlhbCBwYWdlLgoKVGhpcyBwYXRjaCBmaXhlcyB0aGUg
aXNzdWUgYnkgcmVwbGFjaW5nIFhMb2dCYWNrZ3JvdW5kRmx1c2goKSBieQpYTG9nRmx1c2goR2V0
WExvZ0luc2VydFJlY1B0cigpKSwgZmx1c2hpbmcgYWxsIHBlbmRpbmcgcmVjb3JkcyB3aXRob3V0
CmRlcGVuZGluZyBvbiBhc3luYyBMU04gdG8gYmUgdXAgdG8gZGF0ZS4KLS0tCiBzcmMvYmFja2Vu
ZC9yZXBsaWNhdGlvbi93YWxzZW5kZXIuYyB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2Vy
dGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3JlcGxpY2F0
aW9uL3dhbHNlbmRlci5jIGIvc3JjL2JhY2tlbmQvcmVwbGljYXRpb24vd2Fsc2VuZGVyLmMKaW5k
ZXggMmNkZThlYmM3MjkuLjVhNmE2MTg2NzhkIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9yZXBs
aWNhdGlvbi93YWxzZW5kZXIuYworKysgYi9zcmMvYmFja2VuZC9yZXBsaWNhdGlvbi93YWxzZW5k
ZXIuYwpAQCAtMTg4Niw3ICsxODg2LDcgQEAgV2FsU25kV2FpdEZvcldhbChYTG9nUmVjUHRyIGxv
YykKIAkJICogd3JpdHRlbiwgYmVjYXVzZSB3YWx3cml0ZXIgaGFzIHNodXQgZG93biBhbHJlYWR5
LgogCQkgKi8KIAkJaWYgKGdvdF9TVE9QUElORykKLQkJCVhMb2dCYWNrZ3JvdW5kRmx1c2goKTsK
KwkJCVhMb2dGbHVzaChHZXRYTG9nSW5zZXJ0UmVjUHRyKCkpOwogCiAJCS8qCiAJCSAqIFRvIGF2
b2lkIHRoZSBzY2VuYXJpbyB3aGVyZSBzdGFuZGJ5cyBuZWVkIHRvIGNhdGNoIHVwIHRvIGEgbmV3
ZXIKLS0gCjIuNTIuMAoK
--00000000000053035f064c2eef41--