public inbox for [email protected]  

help / color / mirror / Atom feed

From: Ewan Young <[email protected]>
To: Nitin Motiani <[email protected]>
Cc: Zsolt Parragi <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] Fix for bug #19474: LIKE fails to match literal backslashes with nondeterministic collations
Date: Mon, 8 Jun 2026 15:59:59 +0800
Message-ID: <CAON2xHMmoS790vPuhPWvfOXQVmVi9vovOtTkd2AYLXS33CD_6A@mail.gmail.com> (raw)
In-Reply-To: <CAH5HC94r6aRJAVOqUiO=eAt3hvBA3r=H77y8qd3cV2pzOskQUA@mail.gmail.com>
References: <CAH5HC94yU+K8Gcdy12M5BS8gwD_SXLSHzc9k5tNk7JDnpBiFMA@mail.gmail.com>
	<CAN4CZFP4nZnFvjj7OOLsm9UmG=rdy8w8xk2kKAGL-Yng6n8buQ@mail.gmail.com>
	<CAH5HC96PzfLzNAemhxPMdKRO7U+ubXCkq5zhYxNzm_YoP+VpgQ@mail.gmail.com>
	<CAH5HC97_PzdSQNs9bsZS91bLRnpdhz99dWnxe5nRJqD7SbUh-Q@mail.gmail.com>
	<CAON2xHOJKPkcz8vkj7RVaE_U-3T_iVkj5Vwi0=d+Bg=VYiS_1A@mail.gmail.com>
	<CAH5HC94r6aRJAVOqUiO=eAt3hvBA3r=H77y8qd3cV2pzOskQUA@mail.gmail.com>

Hi Nitin,

Thanks for v3.

I re-applied it on top of current master (4cb2a986) and re-ran the
regression suite: all 245 tests pass, and the collate.icu.utf8 set now
covers both directions of the bug, including the false-positive case
('backslash' LIKE 'back\\slash%' -> f).

LGTM, and changed commitfest status to "Ready for Commiter".

Regards,
Ewan Young

On Sat, Jun 6, 2026 at 8:25 PM Nitin Motiani <[email protected]> wrote:
>
> > I reviewed the v2 patch.
> >
>
> Thanks for the feedback.
>
> >
> > 1. The commit message describes the symptom as "an incorrect match
> > failure", but the bug also causes incorrect matches in the other
> > direction. Since the unescaping logic dropped the literal backslash
> > from the pattern, a text *without* a backslash could wrongly match a
> > pattern that requires one:
> >
> >     SELECT 'backslash' COLLATE ignore_accents LIKE 'back\\slash%';
> >     -- unpatched: t (wrong), patched: f (correct)
> >
> > I think it's worth mentioning this false-positive side of the bug in
> > the commit message, since silently-too-permissive LIKE filters are
> > arguably the more dangerous symptom for applications.
> >
>
> I have updated the commit message. I also added another test for this
> scenario in v3.
>
> > 2. A small typo in the new comment in like_match.c:
> > "occurences" should be "occurrences".
> >
>
> Fixed the typo.
>
> Thanks,
> Nitin Motiani
> Google

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Fix for bug #19474: LIKE fails to match literal backslashes with nondeterministic collations
  In-Reply-To: <CAON2xHMmoS790vPuhPWvfOXQVmVi9vovOtTkd2AYLXS33CD_6A@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox