MIME-Version: 1.0
References: <83C44AB4-24B0-437F-B139-B5CBC5821BB1@yesql.se>
 <CA+hUKGJ+WyJ26QGvO_nkgvbxgw+03U4EQ4Hxw+QBft6Np+XW7w@mail.gmail.com>
 <CAOYmi+mf+hw7x+E3XkRypEGy=yR3n6zowjjXeXaSK20WxX3UGw@mail.gmail.com>
 <CAOYmi+kr-Eh7utEDZBFq8Mc9byLLRF3ZNc0TaHt78SKwB4T5KA@mail.gmail.com>
 <CA+hUKGL3yYmKmNHw1wnpuhCbqaiDw1DDUhghEDrh6y97Ygzw9Q@mail.gmail.com>
 <CAOYmi+kOyST1DoF1WOMQvf75L56LiLHZR2+3qTJ+QCg2KC8raQ@mail.gmail.com>
 <CA+hUKGL59uY=UpCHEmTL6dpzuWJBVf1Kc4bQADYDEWG9ZDCffA@mail.gmail.com>
 <CAOYmi+k6HUMK4XQAfnxsmgs1oPOKnchyj2O2a+R7H9jOTU4LPQ@mail.gmail.com>
 <CA+hUKG+mUfH81RuYm5fJrOxdm85hvxLEm=KxXm+n-12FJJH9jA@mail.gmail.com>
 <CAOYmi+nk-KHGGBHz6BGik4+xHPmyPrwOj3ezSM3F4d=-kH_n2Q@mail.gmail.com>
 <CAOYmi+n4EDOOUL27_OqYT2-F2rS6S+3mK-ppWb2Ec92UEoUbYA@mail.gmail.com>
 <CAOYmi+nGstyp4OyL8SFCm3dtkBzNJqGwL7xYhe85=j2hhaXAMw@mail.gmail.com>
 <32e5741d-3dc8-4b15-8c56-cfb26483563c@tantorlabs.com>
 <CAOYmi+mRmRHD-fhXErR0kNqL5NMebPw1EEx++mgmrMAwLszCyw@mail.gmail.com>
 <8a611028-51a1-408c-b592-832e2e6e1fc9@tantorlabs.com>
In-Reply-To: <8a611028-51a1-408c-b592-832e2e6e1fc9@tantorlabs.com>
From: Jacob Champion <jacob.champion@enterprisedb.com>
Date: Wed, 2 Jul 2025 07:46:40 -0700
Message-ID: 
 <CAOYmi+=ORLb7mYdLRyrBE5ZGKd74HC4akLF-Vky-yPZCH38=yQ@mail.gmail.com>
Subject: Re: [PoC] Federated Authn/z with OAUTHBEARER
To: Ivan Kush <ivan.kush@tantorlabs.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
 lev.nikolaev@tantorlabs.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAOYmi%2B%3DORLb7mYdLRyrBE5ZGKd74HC4akLF-Vky-yPZCH38%3DyQ%40mail.gmail.com>
Precedence: bulk

On Wed, Jul 2, 2025 at 5:45=E2=80=AFAM Ivan Kush <ivan.kush@tantorlabs.com>=
 wrote:
>
> Thanks for the clarification! I thought linker flags should be installed
> globally for all compilation targets.

Not for libcurl, since the libpq-oauth module split.

> Another question:
>
> Why don't we set LIBS in the configure in "checking for curl_multi_init"
> using LIBCURL_LIBS or LIBCURL_LDFLAGS?
> [...]
> Without these LIBCURL... variables we will check a system libcurl, not
> our local.

Ah, that's definitely a bug. I've tested alternate PKG_CONFIG_PATHs,
but I haven't regularly tested on systems that have no system libcurl
at all. So those header and lib checks need to be moved after the use
of LIBCURL_CPPFLAGS and LIBCURL_LDFLAGS to prevent a false failure.
Otherwise they're only useful for the LIBCURL_LDLIBS assignment.

I wonder if I should just get rid of those to better match the Meson
implementation... but the error messages from the checks will likely
be nicer than compilation failures during the later test programs. Hm.

(Thanks for the report!)

--Jacob