MIME-Version: 1.0
References: <2074634.1744839761@sss.pgh.pa.us>
 <0A3CF5C4-9947-42E3-89A9-34FCF7BA95BA@yesql.se>
 <2078511.1744841564@sss.pgh.pa.us>
 <DCD56158-A642-4954-87FF-9DAD5425F3FF@yesql.se>
 <2084687.1744844690@sss.pgh.pa.us>
 <CAOYmi+n+DHpaEV5hymhufutTgc+S=+pDQfXEUi4hMAV1eO8aTw@mail.gmail.com>
 <2087556.1744846124@sss.pgh.pa.us>
 <0A596D8B-24F3-408F-B89B-B42014B00A05@yesql.se>
 <2202326.1744903233@sss.pgh.pa.us>
 <CAOYmi+mxjW0GhSGPKoOy3TYrFcdTM=5FcUn=u1i7CFhb2303Zg@mail.gmail.com>
 <25801148-284F-41F9-A279-A4CF92623C77@yesql.se>
In-Reply-To: <25801148-284F-41F9-A279-A4CF92623C77@yesql.se>
From: Jacob Champion <jacob.champion@enterprisedb.com>
Date: Mon, 21 Apr 2025 08:33:28 -0700
Message-ID: 
 <CAOYmi+=w3Q-3F=LCr9hPRhiG2HGv6sogGOJW3v9pwpoCD6wN+w@mail.gmail.com>
Subject: Re: jsonapi: scary new warnings with LTO enabled
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAOYmi%2B%3Dw3Q-3F%3DLCr9hPRhiG2HGv6sogGOJW3v9pwpoCD6wN%2Bw%40mail.gmail.com>
Precedence: bulk

On Sat, Apr 19, 2025 at 2:15=E2=80=AFPM Daniel Gustafsson <daniel@yesql.se>=
 wrote:
> Since there is no way to determine if the allocation succeeded from outsi=
de of
> the JSON api it might be better to keep the calloc and explicitly free it=
?

I don't think so; pg_parse_json() will error out quickly, so I don't
see much advantage to the extra code. Raw performance isn't much of a
concern for the out-of-memory case, IMO.

> (Could a JsonLexContextBroken() function be useful perhaps?)

Maybe if there's ever a client that absolutely must initialize a
context before doing a bunch of independent work? But I don't think
that's true here. (Any callers we're converting from the stack API are
going to have short-lived contexts.)

--Jacob