MIME-Version: 1.0
References: <qtclihmrkq67ach3xjxyi4qcksstin5qxwsnkqefkmotxwh4g6@ae2bj6jvcmry>
 <B2FCB6A7-10C4-416D-BA22-240E9FCDCE18@yesql.se>
 <CAOYmi+n4U_g+k1Bfs2eavJdps0qQj3HFDa5i3V1c0m3CLYUWhA@mail.gmail.com>
 <BA41032F-217B-4BDE-9F16-4D237B63DA33@yesql.se>
In-Reply-To: <BA41032F-217B-4BDE-9F16-4D237B63DA33@yesql.se>
From: Jacob Champion <jacob.champion@enterprisedb.com>
Date: Thu, 23 Apr 2026 11:31:34 -0700
Message-ID: 
 <CAOYmi+k6K6VKTZLPtQLHnoSSMRZfH_=x6bHRUC3zf1F9kjyb1Q@mail.gmail.com>
Subject: Re: oauth integer overflow
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Andres Freund <andres@anarazel.de>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000057ed6a065024dc39"
Archived-At: 
 <https://www.postgresql.org/message-id/CAOYmi%2Bk6K6VKTZLPtQLHnoSSMRZfH_%3Dx6bHRUC3zf1F9kjyb1Q%40mail.gmail.com>
Precedence: bulk

--00000000000057ed6a065024dc39
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 23, 2026 at 11:17=E2=80=AFAM Daniel Gustafsson <daniel@yesql.se=
> wrote:
> > Cool. I have one written up and can share it for comparison, if you'd
> > like, but it's fairly verbose and I wonder if there's a better way to
> > do it.
>
> Well, if you're already done then please do share it, and we'll use that =
as a
> starting point.

Attached. The static_assert for the millisecond calculation is the
only part I don't really like, but doing an overflow check on a
calculation that can't overflow int64 is even more verbose/wasteful.

--Jacob

--00000000000057ed6a065024dc39
Content-Type: application/octet-stream;
	name="0001-libpq-oauth-Avoid-overflow-for-very-large-intervals.patch"
Content-Disposition: attachment;
	filename="0001-libpq-oauth-Avoid-overflow-for-very-large-intervals.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mobtcyc70>
X-Attachment-Id: f_mobtcyc70

RnJvbSAyN2RlMzlmNjY3YWIxMmI3ODc3ODE0MmZlNjBlNjM3NmY0ZDQ5ZWMzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWNvYiBDaGFtcGlvbiA8amFjb2IuY2hhbXBpb25AZW50ZXJw
cmlzZWRiLmNvbT4KRGF0ZTogVGh1LCAyMyBBcHIgMjAyNiAwOTo0Njo0MiAtMDcwMApTdWJqZWN0
OiBbUEFUQ0hdIGxpYnBxLW9hdXRoOiBBdm9pZCBvdmVyZmxvdyBmb3IgdmVyeSBsYXJnZSBpbnRl
cnZhbHMKCi0tLQogc3JjL2ludGVyZmFjZXMvbGlicHEtb2F1dGgvb2F1dGgtY3VybC5jIHwgMzgg
KysrKysrKysrKysrKysrKysrLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDI4IGluc2VydGlvbnMo
KyksIDEwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9pbnRlcmZhY2VzL2xpYnBxLW9h
dXRoL29hdXRoLWN1cmwuYyBiL3NyYy9pbnRlcmZhY2VzL2xpYnBxLW9hdXRoL29hdXRoLWN1cmwu
YwppbmRleCBhYmJlZjkzZjk1Zi4uNzBjYzQ3MTBiNTkgMTAwNjQ0Ci0tLSBhL3NyYy9pbnRlcmZh
Y2VzL2xpYnBxLW9hdXRoL29hdXRoLWN1cmwuYworKysgYi9zcmMvaW50ZXJmYWNlcy9saWJwcS1v
YXV0aC9vYXV0aC1jdXJsLmMKQEAgLTI4LDYgKzI4LDcgQEAKICNlcnJvciBsaWJwcS1vYXV0aCBp
cyBub3Qgc3VwcG9ydGVkIG9uIHRoaXMgcGxhdGZvcm0KICNlbmRpZgogCisjaW5jbHVkZSAiY29t
bW9uL2ludC5oIgogI2luY2x1ZGUgImNvbW1vbi9qc29uYXBpLmgiCiAjaW5jbHVkZSAibWIvcGdf
d2NoYXIuaCIKICNpbmNsdWRlICJvYXV0aC1jdXJsLmgiCkBAIC0xMzYsNyArMTM3LDcgQEAgc3Ry
dWN0IGRldmljZV9hdXRoegogCiAJLyogRmllbGRzIGJlbG93IGFyZSBwYXJzZWQgZnJvbSB0aGUg
Y29ycmVzcG9uZGluZyBzdHJpbmcgYWJvdmUuICovCiAJaW50CQkJZXhwaXJlc19pbjsKLQlpbnQJ
CQlpbnRlcnZhbDsKKwlpbnQzMgkJaW50ZXJ2YWw7CiB9OwogCiBzdGF0aWMgdm9pZApAQCAtMTAy
MCw3ICsxMDIxLDcgQEAgcGFyc2VfanNvbl9udW1iZXIoY29uc3QgY2hhciAqcykKICAqIGV4cGVu
c2l2ZSBuZXR3b3JrIHBvbGxpbmcgbG9vcC4pIFRlc3RzIG1heSByZW1vdmUgdGhlIGxvd2VyIGJv
dW5kIHdpdGgKICAqIFBHT0FVVEhERUJVRywgZm9yIGltcHJvdmVkIHBlcmZvcm1hbmNlLgogICov
Ci1zdGF0aWMgaW50CitzdGF0aWMgaW50MzIKIHBhcnNlX2ludGVydmFsKHN0cnVjdCBhc3luY19j
dHggKmFjdHgsIGNvbnN0IGNoYXIgKmludGVydmFsX3N0cikKIHsKIAlkb3VibGUJCXBhcnNlZDsK
QEAgLTEwMzEsOCArMTAzMiw4IEBAIHBhcnNlX2ludGVydmFsKHN0cnVjdCBhc3luY19jdHggKmFj
dHgsIGNvbnN0IGNoYXIgKmludGVydmFsX3N0cikKIAlpZiAocGFyc2VkIDwgMSkKIAkJcmV0dXJu
IChhY3R4LT5kZWJ1Z19mbGFncyAmIE9BVVRIREVCVUdfVU5TQUZFX0RPU19FTkRQT0lOVCkgPyAw
IDogMTsKIAotCWVsc2UgaWYgKHBhcnNlZCA+PSBJTlRfTUFYKQotCQlyZXR1cm4gSU5UX01BWDsK
KwllbHNlIGlmIChwYXJzZWQgPj0gSU5UMzJfTUFYKQorCQlyZXR1cm4gSU5UMzJfTUFYOwogCiAJ
cmV0dXJuIHBhcnNlZDsKIH0KQEAgLTI2MjAsMTAgKzI2MjEsNyBAQCBoYW5kbGVfdG9rZW5fcmVz
cG9uc2Uoc3RydWN0IGFzeW5jX2N0eCAqYWN0eCwgY2hhciAqKnRva2VuKQogCSAqLwogCWlmIChz
dHJjbXAoZXJyLT5lcnJvciwgInNsb3dfZG93biIpID09IDApCiAJewotCQlpbnQJCQlwcmV2X2lu
dGVydmFsID0gYWN0eC0+YXV0aHouaW50ZXJ2YWw7Ci0KLQkJYWN0eC0+YXV0aHouaW50ZXJ2YWwg
Kz0gNTsKLQkJaWYgKGFjdHgtPmF1dGh6LmludGVydmFsIDwgcHJldl9pbnRlcnZhbCkKKwkJaWYg
KHBnX2FkZF9zMzJfb3ZlcmZsb3coYWN0eC0+YXV0aHouaW50ZXJ2YWwsIDUsICZhY3R4LT5hdXRo
ei5pbnRlcnZhbCkpCiAJCXsKIAkJCWFjdHhfZXJyb3IoYWN0eCwgInNsb3dfZG93biBpbnRlcnZh
bCBvdmVyZmxvdyIpOwogCQkJZ290byB0b2tlbl9jbGVhbnVwOwpAQCAtMjk0OSw4ICsyOTQ3LDI4
IEBAIHBnX2ZlX3J1bl9vYXV0aF9mbG93X2ltcGwoUEdjb25uICpjb25uLCBQR29hdXRoQmVhcmVy
UmVxdWVzdFYyICpyZXF1ZXN0LAogCQkJCSAqIFdhaXQgZm9yIHRoZSByZXF1aXJlZCBpbnRlcnZh
bCBiZWZvcmUgaXNzdWluZyB0aGUgbmV4dAogCQkJCSAqIHJlcXVlc3QuCiAJCQkJICovCi0JCQkJ
aWYgKCFzZXRfdGltZXIoYWN0eCwgYWN0eC0+YXV0aHouaW50ZXJ2YWwgKiAxMDAwKSkKLQkJCQkJ
Z290byBlcnJvcl9yZXR1cm47CisJCQkJeworCQkJCQkvKgorCQkJCQkgKiBMT05HX01BWCBtaWxs
aXNlY29uZHMgaXMgMjQgZGF5cyBvbiAzMi1iaXQgcGxhdGZvcm1zLAorCQkJCQkgKiB3aGljaCBm
b3IgbW9zdCBwZW9wbGUgaXMgZ29pbmcgdG8gYmUgZXF1aXZhbGVudCB0byBhCisJCQkJCSAqIGRp
c2FibGVkIHRpbWVyLi4uIGJ1dCBhdm9pZCBvdmVyZmxvdyBpbiBjYXNlIHRoZQorCQkJCQkgKiBj
b21waWxlciBkb2VzIHNvbWV0aGluZyB1bmludHVpdGl2ZS4KKwkJCQkJICovCisJCQkJCWludDY0
CQlpbnRlcnZhbF9tczsKKworCQkJCQkvKgorCQkJCQkgKiBJZiB5b3UgdHJpcCBvdmVyIHRoaXMs
IHRoZSBtdWx0aXBsaWNhdGlvbiBoZXJlIG5lZWRzIHRvCisJCQkJCSAqIGJlIGFkanVzdGVkIGZv
ciBvdmVyZmxvdyB0b28uCisJCQkJCSAqLworCQkJCQlzdGF0aWNfYXNzZXJ0KHNpemVvZihhY3R4
LT5hdXRoei5pbnRlcnZhbCkgPD0gNCk7CisKKwkJCQkJaW50ZXJ2YWxfbXMgPSBhY3R4LT5hdXRo
ei5pbnRlcnZhbCAqICgoaW50NjQpIDEwMDApOworCQkJCQlpZiAoaW50ZXJ2YWxfbXMgPiBMT05H
X01BWCkKKwkJCQkJCWludGVydmFsX21zID0gTE9OR19NQVg7CisKKwkJCQkJaWYgKCFzZXRfdGlt
ZXIoYWN0eCwgKGxvbmcpIGludGVydmFsX21zKSkKKwkJCQkJCWdvdG8gZXJyb3JfcmV0dXJuOwor
CQkJCX0KIAogCQkJCS8qCiAJCQkJICogTm8gQ3VybCByZXF1ZXN0cyBhcmUgcnVubmluZywgc28g
d2UgY2FuIHNpbXBsaWZ5IGJ5IGhhdmluZwotLSAKMi4zNC4xCgo=
--00000000000057ed6a065024dc39--