Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u7NYx-00FJej-Gm for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Apr 2025 00:02:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1u7NYv-001bL1-Dd for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Apr 2025 00:02:02 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u7NYv-001bJv-2h for pgsql-hackers@lists.postgresql.org; Wed, 23 Apr 2025 00:02:01 +0000 Received: from mail-qv1-xf2b.google.com ([2607:f8b0:4864:20::f2b]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1u7NYq-001RLV-0D for pgsql-hackers@lists.postgresql.org; Wed, 23 Apr 2025 00:01:57 +0000 Received: by mail-qv1-xf2b.google.com with SMTP id 6a1803df08f44-6f0ad74483fso65328186d6.1 for ; Tue, 22 Apr 2025 17:01:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1745366515; x=1745971315; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bb01UnulTbMPLeDhkpK0mvxvT1/aRxFZ4U0ELS3GdGg=; b=flXOewLEodIABBiyuTpGZRACuhK9WK5fS1Hh0zr12SsFgpbB7cJVrVXac3KRbwJj1V CceXME4OsLqTFr3Vp/qf0bZBOF+GsCyhPV2J2IkYotsGeFFevi33OqVct8sOlUwBcmPc HY/gRGiKNL48bhPaKIfH+nSlWCIM5U2va10/TNodazjI6YiY9/epYOhmEMyOWDqWOdWG G+TwayJfIScq8k6euLNSx8afMwEu4lpUIUXE/Q276rAqy9sCBwDwzH4EIs9LTXwFFyml wqpbEhe3ymcXxwydNs+9r/7P1mfSFrOarxhVlHr6EeQzcCmAs3ry5bgSsTXw6bJ8WT0G TvzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745366515; x=1745971315; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bb01UnulTbMPLeDhkpK0mvxvT1/aRxFZ4U0ELS3GdGg=; b=GIwKi2T+PMCWZApeuJE1cihVUjNHG1q3SE8VGZ9FYTVhdcxFt1IU3mjp5vr61eAQZP ZYeLHGnmfflpS9ON4BKfXrEbfaF7VhG3DOFLrNBwbPjMWTBGIKCLi2w0YoqyI/n4mahI I6j6DAIaiRpgUgwf242RHQNrvSEOB/H8DWUFRBDRtvS0dTase3Gyh2Lp0tLSVQxXGfq9 sK6w9dRGChVvii5VGpwSyfsLqBBo/NYA7i6B729Y9RXgVR+5hs69SCVSQVv/7NXWu5Lg Ww9yj59TebT02I0R8tG6fsiXF3ZNfmU7p3CuVARNHOvt1wcr3MG+XluXFNgwDa79tRZU Z7dw== X-Forwarded-Encrypted: i=1; AJvYcCVKZsgtJE4RPd7ix71F5NjWYDBNLa656DKss5o7FXKYLv5CeBJLYUXW+6zLRwoG2edKX0tGyLFDh06zkq3T@lists.postgresql.org X-Gm-Message-State: AOJu0YydSeuFbEPwwh+xwprS/1SXtzkOpHCLUwlRhupaonSJQfxeTa7R T4uJjooIxeCeDjYKFtokMA1/Q9f/X+jODFH7sWsF1C4hLckshPJp8TLh8vAr8OsK6mT4nsMNK2a Vm1Pxpa3ccNb3R5qvhN1Fv6dUA/vZ4DaT8K7f X-Gm-Gg: ASbGncsilIR7ZaMVbGR7wIwQ1hKWebUg33GGtYodjD5SQR0Vd85wm/UrKRZlVoPe100 bBhO0N6nTOpU7Oy+Mxv3lgyEeA+3ItfxCLZbbAK9DmHsQuz7UoinRV7wRW3CbZt+J/wcOAclOO3 8OS8rIsWRMUwM06y9ZgBAb X-Google-Smtp-Source: AGHT+IGGAokcZ1cDMSrCk/sc/KuczZHEidZrAbwfNTO5cH2gkVDgy3d+nZWPjYU8hRBfjkp7CJdXnqgMsLspy20pPjE= X-Received: by 2002:ad4:5bac:0:b0:6e6:6713:3ea8 with SMTP id 6a1803df08f44-6f2c4574d22mr326410556d6.23.1745366515521; Tue, 22 Apr 2025 17:01:55 -0700 (PDT) MIME-Version: 1.0 References: <2074634.1744839761@sss.pgh.pa.us> <0A3CF5C4-9947-42E3-89A9-34FCF7BA95BA@yesql.se> <2078511.1744841564@sss.pgh.pa.us> <2084687.1744844690@sss.pgh.pa.us> <2087556.1744846124@sss.pgh.pa.us> <0A596D8B-24F3-408F-B89B-B42014B00A05@yesql.se> <2202326.1744903233@sss.pgh.pa.us> <25801148-284F-41F9-A279-A4CF92623C77@yesql.se> <102E1997-FB99-4091-926C-9A8BB3EA168E@yesql.se> <0C92C876-09A3-483C-82C5-E26F0C1B34B5@yesql.se> In-Reply-To: <0C92C876-09A3-483C-82C5-E26F0C1B34B5@yesql.se> From: Jacob Champion Date: Tue, 22 Apr 2025 17:01:44 -0700 X-Gm-Features: ATxdqUF2G6fM5x6TFvKS7tVBmlceVoeGgXpdxzN6_EqKmlINV1c1p_UAX7ZVOjM Message-ID: Subject: Re: jsonapi: scary new warnings with LTO enabled To: Daniel Gustafsson Cc: Tom Lane , PostgreSQL Developers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Apr 22, 2025 at 3:10=E2=80=AFAM Daniel Gustafsson = wrote: > My preference is that no operation can silently work on a failed object, = but > it's not a hill (even more so given where we are in the cycle). Hm, okay. Something to talk about with Andrew and Peter, maybe. > The attached > v3 allocates via the JSON api, no specific error handling should be requi= red as > it's already handled today. pgindent shows one whitespace change on my machine (comment indentation), but other than that, LGTM! Fuzzers are happy too. Thanks, --Jacob